Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing query with wrong platform in metadata, adding a unit test for it #2902 #2903

Conversation

rogeriopeixotocx
Copy link
Contributor

Closes #2902

Proposed Changes

  • Fixing the wrong platform field in the query's metadata
  • adding more unit tests to catch this in the future

I submit this contribution under Apache-2.0 license.

@rogeriopeixotocx rogeriopeixotocx added bug Something isn't working terraform Terraform query tests Automated testing labels Apr 19, 2021
@rogeriopeixotocx rogeriopeixotocx added this to the Quality milestone Apr 19, 2021
@rogeriopeixotocx rogeriopeixotocx self-assigned this Apr 19, 2021
Copy link
Collaborator

@joaoReigota1 joaoReigota1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit bf14ee2 into master Apr 20, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the bugfix/wrong-platform-in-non-kube-system-host-mount-query branch April 20, 2021 10:58
@rogeriopeixotocx rogeriopeixotocx changed the title Fixing wrong platform and adding unit tests #2902 Fixing query with wrong platform in metadata, adding a unit test for it #2902 Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working terraform Terraform query tests Automated testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong platform in query metadata non_kube_system_pod_with_host_mount for Terraform
3 participants