Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KICS panics when parsing ansible vault file #4223

Closed
fjsnogueira opened this issue Sep 17, 2021 · 0 comments · Fixed by #4224
Closed

KICS panics when parsing ansible vault file #4223

fjsnogueira opened this issue Sep 17, 2021 · 0 comments · Fixed by #4224
Assignees
@joaoReigota1
Labels
ansible Ansible query bug Something isn't working
Milestone
Core Engineering

Comments

@fjsnogueira
Copy link
Contributor

fjsnogueira commented Sep 17, 2021 •
edited by rogeriopeixotocx
Loading

Expected Behavior

should not panic when scanning encrypted ansible vault yamls

Actual Behavior

KICS panics when finds a file like the example:

vars/all.yaml

$ANSIBLE_VAULT;1.2;AES256;dev
          30613233633461343837653833666333643061636561303338373661313838333565653635353162
          3263363434623733343538653462613064333634333464660a663633623939393439316636633863
          61636237636537333938306331383339353265363239643939666639386530626330633337633833
          6664656334373166630a363736393262666465663432613932613036303963343263623137386239
          6330

Steps to Reproduce the Problem

  1. Execute KICS against sample
  2. Check error in stdout

Specifications

  • Version: 1.4.2
  • Platform: Windows
@fjsnogueira fjsnogueira added the bug Something isn't working label Sep 17, 2021
@rogeriopeixotocx rogeriopeixotocx changed the title Kics panics when parsing ansible vault file KICS panics when parsing ansible vault file Sep 17, 2021
@rogeriopeixotocx rogeriopeixotocx added this to the Core Engineering milestone Sep 17, 2021
@rogeriopeixotocx rogeriopeixotocx added the ansible Ansible query label Sep 17, 2021
@joaoReigota1 joaoReigota1 mentioned this issue Sep 17, 2021
Merged
rogeriopeixotocx pushed a commit that referenced this issue Sep 17, 2021
@joaoReigota1
fix(parser): fix issue with parser returning panic #4223 (#4224)
799ebf4 
Signed-off-by: João Reigota <[email protected]>
@ppanchal10 ppanchal10 mentioned this issue Sep 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaoReigota1 joaoReigota1

Labels
ansible Ansible query bug Something isn't working
Projects
None yet
Milestone
Core Engineering
Development

Successfully merging a pull request may close this issue.

fix(parser): fix issue with parser returning panic #4223 Checkmarx/kics
3 participants
@fjsnogueira @joaoReigota1 @rogeriopeixotocx