Fixed bug with Detect line does not work for OpenAPI template path #3386

Signed-off-by: João Reigota <[email protected]>

assets/queries/openAPI/parameter_object_undefined_type/test/positive_expected_result.json

@@ -8,7 +8,7 @@
   {
     "queryName": "Parameter Object With Undefined Type",
     "severity": "INFO",
-    "line": 7,
+    "line": 55,
     "filename": "positive1.json"
   },
   {
@@ -20,7 +20,7 @@
   {
     "queryName": "Parameter Object With Undefined Type",
     "severity": "INFO",
-    "line": 5,
+    "line": 40,
     "filename": "positive2.yaml"
   },
   {

pkg/detector/helper.go

@@ -26,6 +26,10 @@ func GetBracketValues(expr string, list [][]string, restOfString string) [][]str
 	var tempList []string
 	firstOpen := strings.Index(expr, "{{")
 	firstClose := strings.Index(expr, "}}")
+	// in case we have '}}}' we need to advance one position to get the close
+	for firstClose+2 < len(expr) && string(expr[firstClose+2]) == `}` && firstClose != -1 {
+		firstClose++
+	}
 	switchVal := firstClose - firstOpen
 	if switchVal == 0 { // if there is no "{{" and no "}}"
 		if expr != "" {

pkg/detector/helper_test.go

@@ -113,6 +113,18 @@ func TestGetBracketValues(t *testing.T) {
 				},
 			},
 		},
+		{
+			name: "single_brackets",
+			args: args{
+				expr: "paths.{{user/{id}}}",
+			},
+			want: [][]string{
+				{
+					"{{user/{id}}}",
+					"user/{id}",
+				},
+			},
+		},
 	}
 
 	for _, tt := range tests {