deps: Bump github.com/filecoin-project/lassie from 0.12.2 to 0.13.0 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [github.com/filecoin-project/lassie](https://github.com/filecoin-project/lassie) from 0.12.2 to 0.13.0. - [Release notes](https://github.com/filecoin-project/lassie/releases) - [Changelog](https://github.com/filecoin-project/lassie/blob/main/.goreleaser.yaml) - [Commits](filecoin-project/lassie@v0.12.2...v0.13.0) --- updated-dependencies: - dependency-name: github.com/filecoin-project/lassie dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
Signed-off-by: Miroslav Bajtoš <[email protected]>
github-actions
bot
deleted the
dependabot/go_modules/github.com/filecoin-project/lassie-0.13.0
branch
| @@ -100,10 +100,6 @@ func InitDaemon(cfg *C.daemon_config_t) C.daemon_init_result_t { | |||
| // TODO: configure bitswap concurrency | |||
| // lassieOpts = append(lassieOpts, lassie.WithBitswapConcurrency(bitswapConcurrency)) | |||
|
|
|||
| if tempDir != "" { | |||
| lassieOpts = append(lassieOpts, lassie.WithTempDir(tempDir)) | |||
| } | |||
There was a problem hiding this comment.
doesn't this need changes in other parts too, if we can't pass a temp dir any more?
There was a problem hiding this comment.
I am glad you asked.
We are still providing temp-dir configuration to Lassie's HTTP sever.
Here is the Lassie PR removing lassie.WithTempDir API: filecoin-project/lassie#290. I don't fully understand all ramifications of that change, but I believe it should not affect us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/filecoin-project/lassie from 0.12.2 to 0.13.0.
Release notes
Sourced from github.com/filecoin-project/lassie's releases.
Commits
da0ac6bchore(version): update for v0.13.095981f7refactor(remove config for daemon func):1c726fffix: comment out default tempdir tests for ci3fb1e16fix: only parse full IPNI endpoint URIs7eab5e7test: add daemon and fetch cli flag tests903b161refactor: move lassie instantiation to a common function9329871test: slow down CandidateFinder test to avoid clock race1526265feat: upgrade deps, expose http utility methods0dff3cadoc: document session Config fields5fd6cddfeat!: remove TempDir option; only rely on req.PreloadLinkSystemDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)