finished notification and mentions #12
Conversation
…ations to the notification
…ned or replied to the current user. updated the notification for when other reply ot mention current user
There was a problem hiding this comment.
Hey, @theonej203 this is s good starting point but I got some feedback.
|
|
||
| import './../styles/slide.css'; | ||
|
|
||
| interface notificationProp { |
There was a problem hiding this comment.
Use Pascal Case for type definitions
| import './../styles/slide.css'; | ||
|
|
||
| interface notificationProp { | ||
| notification: SystemSentMessageNotification ; |
There was a problem hiding this comment.
This should be typed as Notification
|
|
||
| interface notificationProp { | ||
| notification: SystemSentMessageNotification ; | ||
| isMentionNotification?: boolean | null; |
There was a problem hiding this comment.
This flag shouldn't be part of the NotificationProps.
| cursor: 'pointer', | ||
| }} | ||
| > | ||
| {isUserMessage(notification.data.message) && ( |
There was a problem hiding this comment.
Consider using the isUserMentionedNotification helper type function instead.
There was a problem hiding this comment.
using isUserMentionedNotification will need additional unnecessary code
src/fragments/FileMessage.tsx
Outdated
| @@ -17,7 +17,12 @@ const FileMessage: React.FC<FileMessageProp> = ({ | |||
|
|
|||
| useEffect(() => { | |||
| getURLFile(message.file.url).then((blob) => { | |||
| setLink(URL.createObjectURL(blob)); | |||
| if(blob){ | |||
There was a problem hiding this comment.
Run prettier to fix this formatting
src/fragments/MessageListItem.tsx
Outdated
| @@ -66,6 +75,18 @@ const MessageListItem: React.FC<MessageListItemProps> = ({ | |||
| } | |||
| }, []); | |||
|
|
|||
| useEffect(() => { | |||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
There was a problem hiding this comment.
The any cast here isn't necessary. Use the isTextMessage type helper function to check if the message is a TextMessage and then access the mentions property.
src/fragments/MyChannels.tsx
Outdated
| @@ -52,11 +60,46 @@ const MyChannels: React.FC = () => { | |||
| }); | |||
| }, [currentUser]); | |||
|
|
|||
| useEffect(() => { | |||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
| const test: any = currentNotification?.data.message; | |||
There was a problem hiding this comment.
The SDK provides type helper functions to prevent unsafe type casting.
isSystemSentMessageNotification
isUserSentMessageNotification
isUserRepliedToMessageNotification
isUserMentionedNotification
isUserMentionedChannelNotification
No description provided.