Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tts #5459
add tts #5459
Changes from 10 commits
2f410fc
93f1762
f86b220
e9f90a4
ed5aea0
d8b1781
318e098
c5168c2
212605a
3ae8ec1
dfaafe3
a3b6647
10d7a64
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implement the
speech
method.The
speech
method has been added to theClaudeApi
class, but it is not yet implemented and throws an error. To provide the intended speech functionality, please implement the method body to handle theSpeechOptions
parameter and return aPromise<ArrayBuffer>
.Do you want me to generate a sample implementation for the
speech
method or open a GitHub issue to track this task?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Speech method added but not implemented.
The
speech
method has been added to theDoubaoApi
class, suggesting an intention to support speech-related functionality in the future. However, the method is currently not implemented and throws an error.Consider the following suggestions:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Complete the implementation of the
speech
method.The
speech
method has been added to theGeminiProApi
class, but the method body is currently throwing an error indicating that it is not implemented. To enable the speech functionality, please complete the implementation of the method body.Consider the following:
SpeechOptions
.Promise<ArrayBuffer>
as per the method signature.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Complete the implementation of the
speech
function.The
speech
function is currently unimplemented and throws an error. This could lead to runtime exceptions if the function is called.Consider adding a TODO comment to track the pending implementation:
+ // TODO: Implement speech function speech(options: SpeechOptions): Promise<ArrayBuffer> { throw new Error("Method not implemented."); }
Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
θΏιmodelηζδΉζ―οΌε₯½ε沑η¨ε°οΌ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
δΈι’ speech ιη¨ε°δΊ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pathθΏδΈͺε½ζ°ιι’ε₯½ε沑η¨ε°ε§οΌζ²‘ηε°ε
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implement the
speech
function or remove the placeholder.The
speech
function has been added to theHunyuanApi
class, but it is not yet implemented. The function currently throws an error indicating that the method is not implemented.Please consider the following:
SpeechOptions
type imported from../api
to understand the expected input for this function.