follow the rabbit to fix potential issues

ChatGPTNextWeb · Oct 13, 2024 · 39f5d26 · 39f5d26
1 parent e64a4f2
commit 39f5d26
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 24 deletions.
diff --git a/app/components/chat.tsx b/app/components/chat.tsx
@@ -1122,12 +1122,11 @@ function _Chat() {
   };
 
   const updateMessageAudio = (msgId?: string, audio_url?: string) => {
-    chatStore.updateCurrentSession(
-      (session) =>
-        (session.messages = session.messages.map((m) =>
-          m.id === msgId ? { ...m, audio_url } : m,
-        )),
-    );
+    chatStore.updateCurrentSession((session) => {
+      session.messages = session.messages.map((m) =>
+        m.id === msgId ? { ...m, audio_url } : m,
+      );
+    });
   };
 
   const onDelete = (msgId: string) => {
@@ -1903,7 +1902,6 @@ function _Chat() {
                     )}
                     {message.audio_url && (
                       <audio
-                        id="audio"
                         preload="auto"
                         controls
                         className={styles["chat-message-item-audio"]}

diff --git a/app/styles/globals.scss b/app/styles/globals.scss
@@ -403,8 +403,9 @@ pre {
 audio {
   height: 35px;
 }
-
 audio::-webkit-media-controls-play-button,
- audio::-webkit-media-controls-panel {
- background-color: none;
- }
+audio::-webkit-media-controls-panel,
+audio::-moz-media-controls-play-button,
+audio::-moz-media-controls-panel {
+  background: none;
+}
diff --git a/app/utils.ts b/app/utils.ts
@@ -251,19 +251,6 @@ export function getMessageImages(message: RequestMessage): string[] {
   return urls;
 }
 
-//export function getMessageAudio(message: RequestMessage): string[] {
-//  if (typeof message.content === "string") {
-//    return [];
-//  }
-//  const urls: string[] = [];
-//  for (const c of message.content) {
-//    if (c.type === "image_url") {
-//      urls.push(c.image_url?.url ?? "");
-//    }
-//  }
-//  return urls;
-//}
-
 export function isVisionModel(model: string) {
   // Note: This is a better way using the TypeScript feature instead of `&&` or `||` (ts v5.5.0-dev.20240314 I've been using)
 

diff --git a/app/utils/audio.ts b/app/utils/audio.ts
@@ -90,6 +90,9 @@ export function arrayBufferToWav(buffer: ArrayBuffer): ArrayBuffer {
 
 // Helper function to write a string to the DataView
 function writeString(view: DataView, offset: number, string: string) {
+  if (offset + string.length > view.byteLength) {
+    throw new Error("String is too long for the available space in DataView");
+  }
   for (let i = 0; i < string.length; i++) {
     view.setUint8(offset + i, string.charCodeAt(i));
   }