Remove stopwords refacture

[mowolf]

• refactured removeStpwords

[Nilegfx]

What does this line do?

[mowolf]

This creates a new object. So that we don not mutate the original object, but instead have two separate ones.

[Nilegfx]

but this is not what this line does. check Object.assign method documentation.

[mowolf]

The Object.assign() method is used to copy the values of all enumerable own properties from one or more source objects to a target object. It will return the target object.

Check out this codepen. Here I create a new object and then manipulate it without the first object being mutated.
https://codepen.io/mowolf/pen/pKjGyb?editors=0012

[Nilegfx]

as discussed, this is risky as it mutates the original object.

[mowolf]

see comment above. Should be fine if this is a separate object.

[Nilegfx]

stopords -> stopWords

[mowolf]

jep

[Nilegfx]

better to save STOPWORDS in a separate file as it is localization not code constants

[mowolf]

jep

[Nilegfx]

right now this function depends on (tightly coupled with) the actual words. so in your tests you have to use one of these words from the original stopwords.

to avoid this behavior, we could do one of:

• Mock STOPWORDS during the test (which is a bit complicated)
• as STOPWORDS is a dependency that we can inject to this function and in tests we can inject different "simplified" words.

for example:

export const createRemoveStopwords =(stopwords)=> (wordCountObject, language) => {
// logic here .. 
}

and then we export another function like that:

export const removeStopwords(STOPWORDS);

and when we test, we use custom/simple stop words:

+import { createRemoveStopwords } from './removeStopwords';

it( 'should remove stopords', () => {
    let stopWords = {'en': ['word1', 'stopword2', 'thirdword']}
    let mockedWords = { 'word1': 1, 'stays': 1, "'stopword2": 1,"'thirdword":1};
    let mockedLanguage = 'en';
    let expectedResult = {
      'stays': 1
    };

    let result = removeStopwords( mockedWords, mockedLanguage );
    expect( result ).toEqual( expectedResult );

  } );
} );

[mowolf]

I do not really understand what you mean by this:

right now this function depends on (tightly coupled with) the actual words. so in your tests you have to use one of these words from the original stopwords.

[mowolf]

I dont know why the other tests that are not related fail...

[mowolf]

I have also no Idea why the check works now... However now it seems fine