Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always FetchContent #31

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Always FetchContent #31

merged 5 commits into from
Jul 6, 2023

Conversation

kwabenantim
Copy link
Member

Fixes #30

@kwabenantim kwabenantim added the bug label Jul 5, 2023
@kwabenantim kwabenantim self-assigned this Jul 5, 2023
@kwabenantim kwabenantim marked this pull request as ready for review July 5, 2023 15:09
@kwabenantim
Copy link
Member Author

kwabenantim commented Jul 5, 2023 •
edited
Loading

Changes

  • Switched from CMake FetchContent to CMake file download for finer control over which files get downloaded and when.
  • Changed default cellml location from src/cellml/cellml to src/cellml.
  • Updated documentation references to FetchContent and src/cellml/cellml.

@kwabenantim kwabenantim requested a review from mirams July 5, 2023 15:26
@kwabenantim
Copy link
Member Author

Tests pass after:

cmake ..
rm -rf src/cellml
cmake ..

https://github.com/Chaste/ApPredict/actions/runs/5465920736/jobs/9950085663

@mirams mirams merged commit 2e5f956 into main Jul 6, 2023
@mirams mirams deleted the issue30_always_fetchcontent branch July 6, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirams mirams Awaiting requested review from mirams

Assignees

@kwabenantim kwabenantim

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Always fetch missing CellML files
2 participants
@kwabenantim @mirams