-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a gradient line chart #649
Conversation
cool! there are conflicts with master could you rebase to fix those? |
It's precisely what I need. Could I help at all moving this PR forward? |
awesome! |
Any update on when this will get merged? |
When it will be ready for merging. |
Hi, any update about this feature? thank you |
hi @Regno nice work , any update about this feature from your side? currently i'm working on swift 3.1 and getting some issues while migrating code from swift 2.1 , It would b great if you help me. Have u migrated this code repo in swift 3.1 ? thanks in advance!!!!!!! |
Any update on this? Would be nice to pull into main repo |
This is what I've been looking for. Would love for it to make it into the main branch. |
Will this also work for fixed stop colours? |
seems not updated to swift 4. @danielgindi This feature has been asked a lot. Shall we go ahead without android support? I think we need a plan for new features that does not sync between iOS and android. waiting for the other one seems will take too long |
Hey @liuxuan30 & @danielgindi . Is there any estimated time of merging this PR? |
Any update when can we expect this feature on master branch ? Thanks! |
Almost 2 years since this very nice pull request. Just wondering, is anyone workin on fixing the merge conflicts? |
I started looking at gradient stuff a while back and haven’t had to time to look through the code and merge/close all issues related to it. From what I remember the timing of this pull request was not ideal since it was in the middle of the refactor from charts v2 to v3. That is why it has taken more time for it to make it in since basically all the code would have to be rewritten in the v3 style. |
There are several projects on github page created and now ongoing as high priority, and this is one of them. I think once we finish the 'more swift' project, we will focus on gradient and the named axis. |
Can you merge this pull request? |
First there needs to be no merge conflicts. @liuxuan30, I think other features can be added while the "More Swift" project is ongoing. If there are any PRs you're uncertain match the Swift-ier style, feel free to tag me. If this is the gradient implementation we are going to go with, we should prioritize it.
|
a long time ago, this PR is almost accepted, except for the code style problems, and then we are uncertain whether to go ahead without porting to android side, so many feature PRs are on hold since then. And Swift 3.0/4.0 kicks in, so more conflicts for this. I think the implementation is accepted, so the next work is we reimplement this on your refactoring base and get it merged, as what I planned. For the Another excuse from me is I spent all most my little free time looking at your PRs and other stuff, other are delayed. |
@liuxuan30 Would you like me to reimplement this in a clean branch so that we can get this merged? Seems like a great feature. |
I would suggest you take some rest :) You already did a lot. |
Made current in #3142 |
Hi, any updates on this? Do you have any idea when this feature will be available? Also, do you think the corresponding branch could be stable enough to use in an app? Thanks! |
1 similar comment
Hi, any updates on this? Do you have any idea when this feature will be available? Also, do you think the corresponding branch could be stable enough to use in an app? Thanks! |
guys... #3415 was merged and will be in version |
When we can expect to get the line gradient chart feature in Chart-iOS (version 4.0.0). As mentioned "guys... #3415 was merged and will be in version 4.0.0 which is not yet out." |
i use. `
` |
The graph draw incorrect(I make the red circle in the attachment) Data points for draw graph:
x: date time in second. This attach is draw in: GMT +7 I'm using: pod 'Charts', :git => 'https://github.com/danielgindi/Charts.git', :branch => '4.0.0' Is it a bug of lib? please help me fix it. Thanks. |
@truongtantri - How did you get the chart to draw those gradient lines? |
@StrauneanuDimitri and data points in my post. |
For #537
Add functionality to draw a gradient line for line chart. It use exist property "colors" and new property "gradientPositions" for rendering gradient line.
Add two new public properties: "gradientPositions" and "drawGradientEnabled" for LineChartDataSet.
Add two new private functions: "drawGradientLine" and "generatePath" for LineChartRenderer
Example of usage:
Result: