Backported @larryonoff’s gradient line drawing implementation from 4.0 to 3.4 #4327
Conversation
|
Wow. Thanks! This's great |
|
This is great! Alternatively the 4.0 branch could be updated to include the changes to master (#4167) |
That would be the best option, but 4.0 has been stale for ~2 years. Not sure if anyone is willing to update it with the latest changes. It would need to be someone who was responsible for the initial 4.0 transition and knows the idea behind this refactoring |
|
since this feature has been in 4.0 branch, #3415, I don't suggest back port to master. If we merge this, then we have to deal with it while merging 4.0, and it's more chanllenging. I'd prefer we merge 4.0 soon. @danielgindi @jjatie opinions? |
|
@liuxuan30 are there any updates on the 4.0 merge? |
|
@Argent could you solve the conflict and make sure CI passes? I do wang to merge 4.0, but since it's a big update, I personally would consider merging some cool features into master first. |
|
oh wait. 4.0 branch already has line graident, this shouldn't come into master. |
|
I don't get feedback about merging 4.0 from other peers. I will need to address it whey they have time to work on this. |
Since the 4.0 branch has been stale for quite a while, but the Gradient Line feature was only implemented there, I decided to back-port it to the 3.4 branch.
All credits for the original implementation go to @larryonoff who developed the feature back in 2018.
Since this is a very important feature for me and I still want to be able to benefit from the improvements that are going on in version 3.x I decided to create a PR to have this feature in the current master branch.
Link to the original PR: #3142