Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed stacked chart bug when there are different stacks on columns. #4029

Merged
merged 2 commits into from
Jul 29, 2019
Merged

fixed stacked chart bug when there are different stacks on columns. #4029

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9364017
fixed stacked chart bug when there are different stacks on columns.
Scalman Jun 16, 2019
40f0dd8
added empty array check
Scalman Jul 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Source/Charts/Renderers/BarChartRenderer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -867,9 +867,12 @@ open class BarChartRenderer: BarLineScatterCandleBubbleRenderer
} else {
stackLabel = nil
}


//Handles empty array of yValues
let yValue = vals.isEmpty ? 0.0 : vals[idx % vals.count]

elementValueText = dataSet.valueFormatter?.stringForValue(
vals[idx % stackSize],
yValue,
entry: e,
dataSetIndex: dataSetIndex,
viewPortHandler: viewPortHandler) ?? "\(e.y)"
Expand Down