Switch from dark color to labelColor to fix darkmode issues.

[Jean-Daniel]

Issue Link 🔗

#3742

Goals ⚽

This change does not fix all Dark mode issues, but is (hopefully) a step in the right direction.

[codecov-io]

Codecov Report

Merging #3766 into master will not change coverage.
The diff coverage is 50%.

@@           Coverage Diff           @@
##           master    #3766   +/-   ##
=======================================
  Coverage   32.67%   32.67%           
=======================================
  Files         114      114           
  Lines       10754    10754           
=======================================
  Hits         3514     3514           
  Misses       7240     7240

Impacted Files	Coverage Δ
Source/Charts/Charts/ChartViewBase.swift	23.17% <ø> (ø)	⬆️
Source/Charts/Utils/Platform.swift	0% <ø> (ø)	⬆️
Source/Charts/Components/ChartLimitLine.swift	0% <ø> (ø)	⬆️
Source/Charts/Components/Description.swift	100% <ø> (ø)	⬆️
Source/Charts/Components/Legend.swift	64.45% <ø> (ø)	⬆️
Source/Charts/Components/AxisBase.swift	60.93% <ø> (ø)	⬆️
...Charts/Data/Implementations/ChartBaseDataSet.swift	14.4% <50%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f2c130...2a8a01f. Read the comment docs.

[thierryH91200]

it's not exactly correct

I did not look at the problem for ios
it can also be done at the program level

extension NSColor
{
    static var labelColor : NSColor
    {
        var labelColor : NSColor
        {
            return NSColor.black
        }
        if #available(OSXApplicationExtension 10.13, *) {
            return NSColor(named: "Color") ?? NSColor.black
        } else {
            return NSColor.black
        }

    }
}

and also create "Assets.xcassets"

[thierryH91200]

in fact the problem is the assignment of the kind

@objc open var gridBackgroundColor = NSUIColor(red: 240/255.0, green: 240/255.0, blue: 240/255.0, alpha: 1.0)

rather
@objc open var gridBackgroundColor = NSUIColor.gridColor
see
open class var placeholderTextColor: NSColor { get }

AppKit
open class var windowFrameTextColor: NSColor { get }
open class var selectedMenuItemTextColor: NSColor { get }
open class var alternateSelectedControlTextColor: NSColor { get }
open class var headerTextColor: NSColor { get }

etc .....

UIKit is poor for the Color

[liuxuan30]

@Jean-Daniel feedback to @thierryH91200?

[Jean-Daniel]

If you want to use custom color and an asset catalog, you should use NSImage(named:bundle:), and place the asset catalog in the framework.

[jjatie]

@thierryH91200 I'm not sure what your issue with this PR is. macOS does provide a default label color for standard and dark modes and we should use it. For UIKit, this happens to be black, but it's reasonable to expect the API to exist in UIKit in the near future as well.

@Jean-Daniel please resolve conflicts

[ChristianVinterly]

I get that this is an old PR, but if UIColor.label is returned here, we can get Dark Mode support for labels on iOS as well, which would be nice.

[jjatie]

Simply removing the declaration will solve the issue for iOS 13+.

extension UIColor {
    @available(iOS, introduced: 9.0, obsoleted: 13.0)
    @available(tvOS, introduced: 9.0, obsoleted: 13.0)
    static var label: UIColor { .black }
}

and doing the same for NSColor

extension NSColor {
    @available(macOS, introduced: 10.11, obsoleted: 10.14)
    static var label: UIColor { .black }
}

[liuxuan30]

I'm going to look at the dark mode stuff recently. I know this is an old pr and there is a new one:#3742, which seems doing the same thing.

from my comment #4171 (comment), we need to talk about a few things before. Can anyone reply? Thanks.