Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update barRect.size.height calculation #3587

Merged
merged 1 commit into from
Jul 29, 2018

Conversation

potato04
Copy link
Contributor

@potato04 potato04 commented Jul 27, 2018

when bottom equals top, offset is not necessary
fix #3586

when bottom equals top, offset is not necessarily
@potato04 potato04 changed the title update barRect.size.height calculation fix #3586 update barRect.size.height calculation Jul 27, 2018
@potato04 potato04 changed the title fix #3586 update barRect.size.height calculation update barRect.size.height calculation Jul 27, 2018
@codecov-io
Copy link

Codecov Report

Merging #3587 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3587   +/-   ##
=======================================
  Coverage   29.94%   29.94%           
=======================================
  Files         118      118           
  Lines       13793    13793           
=======================================
  Hits         4130     4130           
  Misses       9663     9663
Impacted Files Coverage Δ
Source/Charts/Renderers/BarChartRenderer.swift 51.47% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88895d0...881b72e. Read the comment docs.

@pmairoldi pmairoldi merged commit 5a5121d into ChartsOrg:master Jul 29, 2018
@pmairoldi
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bars did not displayed as expect
3 participants