Removes comment about non-existent method #3512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IValueFormatter had a comment suggesting that you can override the getFormattedValue(…) method but that method doesn’t exist. The comment has been removed.
Codecov Report
@@ Coverage Diff @@
## master #3512 +/- ##
=======================================
Coverage 29.26% 29.26%
=======================================
Files 117 117
Lines 13277 13277
=======================================
Hits 3886 3886
Misses 9391 9391Continue to review full report at Codecov.
|
|
Think it may have just been renamed to |
|
Thanks, @philfi. You are correct. I guess that was pretty obvious, huh? I'll update it and push a new commit. Do I close this PR and open a new one or push new changes to this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IValueFormatter had a comment suggesting that you can override the getFormattedValue(…) method but that method doesn’t exist. The comment has been removed.
Issue Link 🔗
#3506