Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pie chart unit tests #3297

Merged
merged 1 commit into from
Feb 25, 2018
Merged

add pie chart unit tests #3297

merged 1 commit into from
Feb 25, 2018

Conversation

liuxuan30
Copy link
Member

add pie chart unit tests

@codecov-io
Copy link

Codecov Report

Merging #3297 into master will increase coverage by 5.44%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3297      +/-   ##
==========================================
+ Coverage   22.87%   28.32%   +5.44%     
==========================================
  Files         116      117       +1     
  Lines       15618    15669      +51     
  Branches      272      320      +48     
==========================================
+ Hits         3573     4438     +865     
+ Misses      12009    11188     -821     
- Partials       36       43       +7
Impacted Files Coverage Δ
Tests/Charts/PieChartTests.swift 100% <100%> (ø)
Source/Charts/Charts/ChartViewBase.swift 22.9% <0%> (+0.54%) ⬆️
Source/Charts/Utils/ViewPortHandler.swift 29.09% <0%> (+0.9%) ⬆️
...Charts/Data/Implementations/ChartBaseDataSet.swift 23.03% <0%> (+1.96%) ⬆️
Source/Charts/Components/Legend.swift 61.84% <0%> (+6.02%) ⬆️
Source/Charts/Renderers/LegendRenderer.swift 48.28% <0%> (+6.65%) ⬆️
Source/Charts/Charts/PieRadarChartViewBase.swift 17.44% <0%> (+17.44%) ⬆️
...a/Implementations/Standard/PieChartDataEntry.swift 22.22% <0%> (+22.22%) ⬆️
Source/Charts/Utils/ChartColorTemplates.swift 26.78% <0%> (+26.78%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64438c4...b88560a. Read the comment docs.

@liuxuan30 liuxuan30 merged commit e29536b into ChartsOrg:master Feb 25, 2018
@liuxuan30 liuxuan30 deleted the PieUT branch February 25, 2018 04:47
FreddyZeng added a commit to FreddyZeng/Charts that referenced this pull request Feb 26, 2018
* 'master' of https://github.com/danielgindi/Charts:
  add pie chart unit tests (ChartsOrg#3297)
  ChartsOrg#3287: align Objc and Swift demos balloon marker
  update changelog
  Min and Max reset when clearing ChartDataSet (Fixes ChartsOrg#3260)

# Conflicts:
#	Source/Charts/Mark/BalloonMarker.swift
FreddyZeng added a commit to FreddyZeng/Charts that referenced this pull request Mar 14, 2018
* master: (55 commits)
  Refactors -[tableView:cellForRowAtIndexPath:] (ChartsOrg#3326)
  fix ChartsOrg#3311. Need one more key for iOS 11 camera roll saving
  revert a mistake, fix ChartsOrg#3299
  add pie chart unit tests (ChartsOrg#3297)
  ChartsOrg#3287: align Objc and Swift demos balloon marker
  update changelog
  Min and Max reset when clearing ChartDataSet (Fixes ChartsOrg#3260)
  Restored old performance (ChartsOrg#3216)
  Support other bundle than main MarkerView.viewFromXib() (ChartsOrg#3215)
  For ChartsOrg#2840. add dataIndex parameter in `highlightValue()` calls (ChartsOrg#2852)
  Balloon Marker indicates position of data (ChartsOrg#3181)
  bump Info.plist version
  Fixed a duplicated assignment compared with obj-c code. (ChartsOrg#3179)
  Updated README for 3.0.5 (ChartsOrg#3183)
  BubbleChart uses correct colour for index now.
  Added custom text alignment for noData
  Fixes the distance issue between the legend and the horizontal bar chart (Fixes ChartsOrg#2138) (ChartsOrg#2214)
  call setNeedsDisplay() here to trigger render noDataText (ChartsOrg#3198)
  添加定制TY的Mark
  添加修改过的Mark到工程中
  ...

# Conflicts:
#	ICXCharts.podspec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants