Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named axis support #2452

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Named axis support #2452

wants to merge 15 commits into from

Conversation

thierryH91200
Copy link
Contributor

@thierryH91200 thierryH91200 commented May 18, 2017

adjust the default font and color values
It's more functional
Seen in use

@codecov-io
Copy link

codecov-io commented May 18, 2017

Codecov Report

Merging #2452 into master will decrease coverage by 0.15%.
The diff coverage is 14.45%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2452      +/-   ##
=========================================
- Coverage   19.65%   19.5%   -0.16%     
=========================================
  Files         112     112              
  Lines       13714   14033     +319     
=========================================
+ Hits         2696    2737      +41     
- Misses      11018   11296     +278
Impacted Files Coverage Δ
Source/Charts/Components/AxisBase.swift 48.73% <ø> (ø) ⬆️
...ts/Renderers/XAxisRendererHorizontalBarChart.swift 0% <0%> (ø) ⬆️
Source/Charts/Charts/HorizontalBarChartView.swift 0% <0%> (ø) ⬆️
...ts/Renderers/YAxisRendererHorizontalBarChart.swift 0% <0%> (ø) ⬆️
Source/Charts/Renderers/YAxisRenderer.swift 49.33% <18.46%> (-6.62%) ⬇️
Source/Charts/Renderers/XAxisRenderer.swift 54.14% <28.98%> (-4.94%) ⬇️
Source/Charts/Charts/BarLineChartViewBase.swift 23.7% <34%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ab1ebd...8a92b71. Read the comment docs.

@thierryH91200 thierryH91200 changed the title Adjusts the default font and color values. Named axis support May 18, 2017
@thierryH91200
Copy link
Contributor Author

I made all the combinations for the position of the legend
There are 18 cases in all x2

  • Line / Bar
  • HorizontalBar
    with
    legend.orientation = .horizontal .vertical
    legend.horizontalAlignment = .right .left .center
    legend.verticalAlignment = .top .bottom .center

I corrected some bugs
Now everything is correct
It's a PR where you have to take your time

I do not understand I can not seem to be on the same PR
It is for this reason that it is duplicate
It is certainly an error on my side

@leo150
Copy link
Contributor

leo150 commented Jun 28, 2017

Bump. Please review that feature 🙏

Volodymyr Kosmirak and others added 2 commits October 13, 2017 11:45
Fixed swapped left and right xAxis’es (in horizontal bar chart with .top and .botton type)
@jjatie
Copy link
Collaborator

jjatie commented Jan 11, 2018

@thierryH91200 can you target this to 4.0.0 and fix conflicts please?

@thierryH91200
Copy link
Contributor Author

@jjatie
yes I can
and the PR #2414 it's a old bug
is this possible ?
this is just 6 lines to remove

@liuxuan30 liuxuan30 added this to the 4.0.0 milestone Jan 17, 2018
@rameswarprasad
Copy link

rameswarprasad commented Jan 17, 2018

@thierryH91200 I think your pull request exists in Swift 3 version, better may be updating to Swift 4.0 or will it work fine while reviewing. I'm not completely sure how that works though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants