Named axis support #2387

thierryH91200 · 2017-04-24T18:53:34Z

add

     axis.nameAxisFont = NSUIFont.systemFont(ofSize: CGFloat(14.0))
       axis.nameAxis = "Day"
       axis.nameAxisTextColor = #colorLiteral(red: 1, green: 0.1491314173, blue: 0, alpha: 1)
       axis.nameAxisEnabled = true

I think it should have success like PR

liuxuan30 · 2017-04-25T01:19:02Z

Wow, you have been helping a lot!
some questions,

do you consider adding some offset for the left/right of the name? (bottom/top for x axis).
seems you forgot horizontal bar chart and radar/pie? Seeing separate axis renderer for them. Maybe we can consolidate in a common place so we can reuse them

Supporting only 90 degree at beginning is fine and we can handle the new test cases later

liuxuan30 · 2017-04-25T01:19:26Z

Source/Charts/Renderers/YAxisRenderer.swift

        }
        else
        {
            if labelPosition == .outsideChart
            {
                textAlign = .left
                xPos = viewPortHandler.contentRight + xoffset
+
+                xPosName = viewPortHandler.chartWidth - 5


what is 5 here?

liuxuan30 · 2017-04-25T01:20:35Z

Source/Charts/Renderers/YAxisRenderer.swift

@@ -44,6 +44,7 @@ open class YAxisRenderer: AxisRendererBase
        let labelPosition = yAxis.labelPosition

        var xPos = CGFloat(0.0)
+        var xPosName = CGFloat(0.0)


xPosName is a little confusing here. how about xNamePos or other style?

liuxuan30 · 2017-04-25T01:27:04Z

Source/Charts/Charts/BarLineChartViewBase.swift

            if xAxis.isEnabled && xAxis.isDrawLabelsEnabled
            {
                let xlabelheight = xAxis.labelRotatedHeight + xAxis.yOffset

+                var size = NSSize()


Travis CI for tvOS and iOS fails here, maybe NSUISize()?

… use CGPoint and CGSize

codecov-io · 2017-04-25T05:50:47Z

Codecov Report

Merging #2387 into master will increase coverage by 0.01%.
The diff coverage is 18.73%.

@@            Coverage Diff             @@
##           master    #2387      +/-   ##
==========================================
+ Coverage   19.66%   19.67%   +0.01%     
==========================================
  Files         112      112              
  Lines       13713    13910     +197     
==========================================
+ Hits         2696     2737      +41     
- Misses      11017    11173     +156

Impacted Files	Coverage Δ
Source/Charts/Components/AxisBase.swift	`48.73% <ø> (ø)`	⬆️
...ts/Renderers/XAxisRendererHorizontalBarChart.swift	`0% <0%> (ø)`	⬆️
Source/Charts/Charts/HorizontalBarChartView.swift	`0% <0%> (ø)`	⬆️
...ts/Renderers/YAxisRendererHorizontalBarChart.swift	`0% <0%> (ø)`	⬆️
Source/Charts/Renderers/YAxisRenderer.swift	`53.16% <21.21%> (-2.79%)`	⬇️
Source/Charts/Renderers/XAxisRenderer.swift	`58.6% <37.5%> (-0.48%)`	⬇️
Source/Charts/Charts/BarLineChartViewBase.swift	`23.7% <38.57%> (+0.26%)`	⬆️
Source/Charts/Charts/ChartViewBase.swift	`24.23% <0%> (-0.06%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc1e965...7f515a2. Read the comment docs.

thierryH91200 · 2017-04-25T06:06:28Z

1 do you consider adding some offset for the left/right of the name? (bottom/top for x axis).
yes i add offset depending on the height of the font

2 seems you forgot horizontal bar chart and radar/pie? Seeing separate axis renderer for them. Maybe we can consolidate in a common place so we can reuse them
I'll take care of it

PieChartView
/// This will throw an exception, PieChart has no XAxis object.
open override var xAxis: XAxis
{
fatalError("PieChart has no XAxis")
}

liuxuan30 · 2017-04-26T02:21:29Z

Oh I forgot. Seems we can ignore pie/radar chart's for now, since their axis is not normal, and we don't have requests for displaying name?

liuxuan30 · 2017-04-26T02:26:47Z

@thierryH91200 I was thinking, if there are demands, such as the inter space between the name and axis line? I see you are just using existing offsetLeft/right/top/bottom for the space between the chart view boundary and the axis name.

I am not sure if we should use separate "axisName Left/Right/Top/Bottom/ Space" for them. Any other people who have ideas?

thierryH91200 · 2017-04-26T13:11:21Z

add HorizontalBarChart

thierryH91200 · 2017-05-05T07:29:43Z

I was not very pleased with me
Complete rewrite of name Axis
Creation of 4 rectangles to preserve the place of the name of the axis
This avoids overlays and has a more readable code

     Open var nameRectBottom = CGRect ()
     Open var nameRectTop = CGRect ()
     Open var nameRectLeft = CGRect ()
     Open var nameRectRight = CGRect ()

For BarLineChartViewBase
NameRectBottom and nameRectTop are associated with xAxis
NameRectLeft is associated with leftAxis
NameRectRight are associated with rightAxis

For HorizontalBarChartView
NameRectLeft and nameRectRight are associated with xAxis
NameRectBottom is associated with rightAxis
NameRectTop is associated with leftAxis

liuxuan30 · 2017-05-05T08:35:08Z

LOL, take your time:)

hungcaobss · 2017-05-22T02:23:15Z

Hi, was this supported for iOS? I have checked in the latest version but don't see it

thierryH91200 · 2017-05-22T06:08:59Z

not reviewed yet.

seenoevo · 2017-08-14T23:37:02Z

please add this feature @danielgindi :)

dhaneshgosai · 2017-09-27T04:45:21Z

Hello @danielgindi,

Is this feature reviewed ?

shashidhar34 · 2018-10-25T17:30:01Z

is this feature in the current released version?

Named axis support

7dd6d73

liuxuan30 reviewed Apr 25, 2017

View reviewed changes

thierryH91200 added 2 commits April 25, 2017 07:32

iOS uses Core Graphics for drawing so instead of NSPoint and NSSize I…

592e101

… use CGPoint and CGSize

It is true that there could be confusion

4583311

It was just a small offset but it's useless , just for the debug

fdf8539

thierryH91200 added 4 commits April 26, 2017 10:47

Named axis support

061b98a

Named axis support

373e9b6

Named axis support

fe48e33

Merge remote-tracking branch 'origin/master'

0b8541b

thierryH91200 added 2 commits April 26, 2017 15:35

Merge remote-tracking branch 'danielgindi/master'

523e5e8

name Axis

7f515a2

liuxuan30 mentioned this pull request May 15, 2017

Named axis support? #35

Open

thierryH91200 closed this May 18, 2017

thierryH91200 mentioned this pull request Aug 10, 2017

Add labels to x-axis and y-axis value types #2694

Open

thierryH91200 mentioned this pull request Sep 27, 2017

Add a title or units for X & Y axis #2827

Open

seenoevo mentioned this pull request Oct 11, 2017

Set names of X-axis and Y-axis itself (not their labels) #2867

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Named axis support #2387

Named axis support #2387

thierryH91200 commented Apr 24, 2017

liuxuan30 commented Apr 25, 2017 •

edited

Loading

liuxuan30 Apr 25, 2017

liuxuan30 Apr 25, 2017

liuxuan30 Apr 25, 2017

codecov-io commented Apr 25, 2017 •

edited

Loading

thierryH91200 commented Apr 25, 2017 •

edited

Loading

liuxuan30 commented Apr 26, 2017

liuxuan30 commented Apr 26, 2017

thierryH91200 commented Apr 26, 2017

thierryH91200 commented May 5, 2017

liuxuan30 commented May 5, 2017

hungcaobss commented May 22, 2017

thierryH91200 commented May 22, 2017

seenoevo commented Aug 14, 2017

dhaneshgosai commented Sep 27, 2017

shashidhar34 commented Oct 25, 2018

Named axis support #2387

Named axis support #2387

Conversation

thierryH91200 commented Apr 24, 2017

liuxuan30 commented Apr 25, 2017 • edited Loading

liuxuan30 Apr 25, 2017

Choose a reason for hiding this comment

liuxuan30 Apr 25, 2017

Choose a reason for hiding this comment

liuxuan30 Apr 25, 2017

Choose a reason for hiding this comment

codecov-io commented Apr 25, 2017 • edited Loading

Codecov Report

thierryH91200 commented Apr 25, 2017 • edited Loading

liuxuan30 commented Apr 26, 2017

liuxuan30 commented Apr 26, 2017

thierryH91200 commented Apr 26, 2017

thierryH91200 commented May 5, 2017

liuxuan30 commented May 5, 2017

hungcaobss commented May 22, 2017

thierryH91200 commented May 22, 2017

seenoevo commented Aug 14, 2017

dhaneshgosai commented Sep 27, 2017

shashidhar34 commented Oct 25, 2018

liuxuan30 commented Apr 25, 2017 •

edited

Loading

codecov-io commented Apr 25, 2017 •

edited

Loading

thierryH91200 commented Apr 25, 2017 •

edited

Loading