when the point of label out of viewPortHandler.contentRect, we should not draw the label #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuxuan30
force-pushed
the
ChartYAxisLabelBug
branch
from
7465af6 to
841dd52
Compare
1.for bar chart, if the label point is out of contentRect vertically, ignore it and continue 2.for horizontal bar chart, if the label point is out of contentRect horizontally, ignore it and continue (+1 squashed commit) Squashed commits: [1a0d195] when the pt.y larger than contentRect height, we should not draw the label
liuxuan30
force-pushed
the
ChartYAxisLabelBug
branch
from
841dd52 to
cb9dc02
Compare
liuxuan30
changed the title
|
Add a horizontal bar chart example to show the bug. there is a -100 label drawn out bound of y axis range. |
|
Hold on, today I met a bug introduced by my commit in ChartYAxisRenderer, the pt.y is actually less than contentRect.origin.y, and it should be drawn. Wondering why. Still pending investigation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the point of label out of viewPortHandler.contentRect, we should not draw the label
1.for bar chart, if the label point is out of contentRect vertically, ignore it and continue
2.for horizontal bar chart, if the label point is out of contentRect horizontally, ignore it and continue