Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Option to Place Limit Line Label Beneath Line #1983

Closed
wants to merge 5 commits into from

Conversation

dtrauger
Copy link

Added option to place limit line label beneath limit line adjusting the line's height accordingly.

@codecov-io
Copy link

codecov-io commented Dec 19, 2016

Codecov Report

❗ No coverage uploaded for pull request base (master@1ed1561). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1983   +/-   ##
=========================================
  Coverage          ?   18.46%           
=========================================
  Files             ?      124           
  Lines             ?    14384           
  Branches          ?        0           
=========================================
  Hits              ?     2656           
  Misses            ?    11728           
  Partials          ?        0
Impacted Files Coverage Δ
Source/Charts/Components/ChartLimitLine.swift 0% <ø> (ø)
Source/Charts/Renderers/XAxisRenderer.swift 57.06% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ed1561...15090e7. Read the comment docs.

@thierryH91200
Copy link
Contributor

@dtrauger

You are sure that update project has a relationship to the problem

refer to #1538

I quote petester42
"Yes you should. It's is one framework for all platforms. The basic setup is macOS but it has been setup to work on all platforms. Having 1 framework makes the development more manageable."

It's dangerous your PR

@pmairoldi
Copy link
Collaborator

As mentioned the project file should be macOS not iphoneos. Please revert the change

@jjatie jjatie added the idea label Jan 23, 2018
@jjatie jjatie added this to the Future milestone Jan 23, 2018
@jjatie
Copy link
Collaborator

jjatie commented Jan 27, 2018

Feel free to reopen if you'd make the requested changes.

@jjatie jjatie closed this Jan 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants