Make sure we render the last y Label on LineCharts (Fixes #1585) #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#1323 is the same issue. This did fix the missing label, however, I found a new issue that when zoomed in, the animation on x axis is not in sync: the value text will jump out first and then come with the line. Changing back to to the animation will be good. awkward... |
|
See my comment on #1323 (comment), I agree this PR alone is not enough, but it looks like there's more to the issue that originally thought, as even without this change the current master "pops" in the last data point when animating. I'm closing this PR and will keep the discussion on #1323. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrong stride termination was causing us to not render the last text value.
Verified the issue in the
ChartsDemoexample, but have not looked closelyat other chart types.