Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bar layout bug, pie callback bug #1452

Merged
merged 2 commits into from
Sep 19, 2016

Conversation

aoverholtzer
Copy link

Fixing two issues:

  1. BarChart right/left bar cut in half (Issue BarChart right/left bar cut in half #1446) notes that if you turn on fitBars, the last bar will be cropped out.
  2. Tapping on a pie chart slice would not trigger any delegate callbacks (no issue). This is fixed by explicitly requesting callbacks in PieRadarChartViewBase’s tap event.

@liuxuan30
Copy link
Member

You mean this happens on Charts v3.0? Not sure if Swift 2.3 branch is the right branch to merge. @danielgindi needs you review on this.

@Huang-Libo
Copy link

Huang-Libo commented Sep 19, 2016

@aoverholtzer
You help me solve my problem, thanks! I fix my problem on Charts v3.0

@liuxuan30
After I update Charts to Latest commit d1daf3e (Merge pull request #1467 from liuxuan30/baseSDK ),the pie chart's delegate can not be called when I tapped on it. Then I changed Charts' source codes which were metioned in this pull requst, everything works well again.

@danielgindi
Copy link
Collaborator

Thank you!

@danielgindi danielgindi merged commit efbbae4 into ChartsOrg:Swift-2.3 Sep 19, 2016
@liuxuan30
Copy link
Member

liuxuan30 commented Sep 20, 2016

@danielgindi did you notice it's merged into swift 2.3 not master? I am going to porting it to master in #1486

liuxuan30 added a commit to liuxuan30/Charts that referenced this pull request Sep 20, 2016
liuxuan30 added a commit that referenced this pull request Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants