Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Version to 4.2.5.1.0 #9

Merged
merged 4 commits into from
Apr 8, 2024
Merged

Update Version to 4.2.5.1.0 #9

merged 4 commits into from
Apr 8, 2024

Conversation

helium-service
Copy link
Contributor

Adapter version '4.2.5.1.0', partner version '~> 2.5.1'

@helium-service helium-service requested review from a team, bwised, ricealexanderb, daniel-barros, kendallrogers and CB-HaoxinLi and removed request for a team February 22, 2024 23:01
@bwised
Copy link
Contributor

bwised commented Feb 22, 2024

Blocked by #7. Branched from release/4.2.5.0.0.

@daniel-barros
Copy link
Member

@bwised can we close this PR and remove the release branch? As discussed, the 2.5.0 update should suffice.

@daniel-barros
Copy link
Member

@bwised can we close this PR and remove the release branch? As discussed, the 2.5.0 update should suffice.

oh wait are we actually releasing a 2.5.1 version?

CHANGELOG.md Outdated Show resolved Hide resolved
@bwised
Copy link
Contributor

bwised commented Feb 22, 2024

Last message from @pleasesavemycat that I saw was to move forward with the ticket assigned to me. If that's no longer true, I can close everything out.

@daniel-barros
Copy link
Member

daniel-barros commented Feb 22, 2024

Last message from @pleasesavemycat that I saw was to move forward with the ticket assigned to me. If that's no longer true, I can close everything out.

maybe I misunderstood sorry, I asked Kelly in the channel to clarify.
this update should be unnecessary, but maybe we want to release it to reduce the chances that some pub uses the bidmachine 2.5.0 version if they haven't done a pod update

@daniel-barros
Copy link
Member

Last message from @pleasesavemycat that I saw was to move forward with the ticket assigned to me. If that's no longer true, I can close everything out.

maybe I misunderstood sorry, I asked Kelly in the channel to clarify. this update should be unnecessary, but maybe we want to release it to reduce the chances that some pub uses the bidmachine 2.5.0 version if they haven't done a pod update

all right Kelly confirmed we are moving forward with the update, sorry for the delay

@kendallrogers kendallrogers merged commit 466ed92 into main Apr 8, 2024
2 checks passed
@kendallrogers kendallrogers deleted the release/4.2.5.1.0 branch April 8, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants