Update Version to 4.3.0.0.0 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helium-service
requested review from
a team,
bwised,
ricealexanderb,
daniel-barros,
kendallrogers and
CB-HaoxinLi
and removed request for
a team
CB-HaoxinLi
reviewed
Jul 26, 2024
| @@ -15,7 +15,7 @@ Pod::Spec.new do |spec| | |||
|
|
|||
| # Minimum supported versions | |||
| spec.swift_version = '5.1' | |||
| spec.ios.deployment_target = '12.0' | |||
| spec.ios.deployment_target = '13.0' | |||
There was a problem hiding this comment.
Do we need to upgrade? BidMachine 3.0.0 supports iOS 12+ and this adapter is not on 5.x yet.
https://github.com/CocoaPods/Specs/blob/master/Specs/4/0/5/BidMachine/3.0.0/BidMachine.podspec.json
There was a problem hiding this comment.
+1
It's not uncommon for ad SDKs to have a minimum supported version while keeping an older one as the podspec deployment target. This way they can still be integrated in apps that have to support old OS versions, although they don't serve ads for them.
There was a problem hiding this comment.
The version should be the same as the partner podspec.
There was a problem hiding this comment.
Lies! Lies in the podspec!
CB-HaoxinLi
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapter version '4.3.0.0.0', partner version '~> 3.0.0'
One change to the code: we're requesting a key from the BidMachine SDK and sending it to the backend so they can use the corresponding endpoint URL for bidding.