Skip to content

Commit

Permalink
[HB-6923] Use canShow method instead of isLoaded (#4)
Browse files Browse the repository at this point in the history
- Switched isLoaded method with canShow method before displaying fullscreen ads.
- Updated Changelog, README, build script to 4.2.4.0.1
  • Loading branch information
cb-jpadilla authored Jan 16, 2024
1 parent 0bb29c0 commit f453f74
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion BidMachineAdapter/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ android {
minSdk = 21
targetSdk = 33
// If you touch the following line, don't forget to update scripts/get_rc_version.zsh
android.defaultConfig.versionName = System.getenv("VERSION_OVERRIDE") ?: "4.2.4.0.0"
android.defaultConfig.versionName = System.getenv("VERSION_OVERRIDE") ?: "4.2.4.0.1"
buildConfigField("String", "CHARTBOOST_MEDIATION_BIDMACHINE_ADAPTER_VERSION", "\"${android.defaultConfig.versionName}\"")

consumerProguardFiles("proguard-rules.pro")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -788,8 +788,8 @@ class BidMachineAdapter : PartnerAdapter {
Result.failure(ChartboostMediationAdException(ChartboostMediationError.CM_SHOW_FAILURE_AD_NOT_FOUND))
}

is InterstitialAd -> canShowAd(ad::isLoaded, ad::show)
is RewardedAd -> canShowAd(ad::isLoaded, ad::show)
is InterstitialAd -> canShowAd(ad::canShow, ad::show)
is RewardedAd -> canShowAd(ad::canShow, ad::show)

else -> {
PartnerLogController.log(
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,8 @@
Note the first digit of every adapter version corresponds to the major version of the Chartboost Mediation SDK compatible with that adapter.
Adapters are compatible with any Chartboost Mediation SDK version within that major version.

### 4.2.4.0.1
- Use BidMachine's `canShow` instead of `isLoaded` before displaying ad.

### 4.2.4.0.0
- This version of the adapter has been certified with BidMachine Ads SDK 2.4.0.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ The Chartboost Mediation BidMachine adapter mediates BidMachine via the Chartboo

In your `build.gradle`, add the following entry:
```
implementation "com.chartboost:chartboost-mediation-adapter-bidmachine:4.2.4.0.0"
implementation "com.chartboost:chartboost-mediation-adapter-bidmachine:4.2.4.0.1"
```

## Contributions
Expand Down

0 comments on commit f453f74

Please sign in to comment.