0.5 closed flag exposed #41
Conversation
…echniques/intention-revealing-code-java-8-optional/) Request handling chain now explicitly throws UnsupportedFeatureException if feature is not found IllegalStateException thrown if active session not found while handling incoming request Communicating internal error if confirmation type is not found Added debug log messages if promise is not found Added debug log messages with request queue size Added debug log messages if feature or request not found while handling incoming confirmation Added warning log message if active session is not found before closing connection Added warning log message if confirmation type was not found
…/toString helpers (cut versions from Guava) String representation added to FeatureRepository and Queue Execution time measurement and logging with debug level added to Queue
| * Copyright (C) 2014 The Guava Authors | ||
| * Modified by Evgeny Pakhomov <[email protected]> | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except |
There was a problem hiding this comment.
You set the license to a different one that the project. How does that work?
There was a problem hiding this comment.
I will consult with our lawyer to be on a safe side but from what I know Apache License 2 is permissive and compliant with MIT as far as its own conditions fullfilled.
There was a problem hiding this comment.
I've checked with lawyer - Apache License 2 is compatible with MIT. Additional restrictions are mostly that when you use it you have to mention changes specifically and you obliged to publish the code. So I've added detailed changes description.
| * Copyright (C) 2014 The Guava Authors | ||
| * Modified by Evgeny Pakhomov <[email protected]> | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except |
There was a problem hiding this comment.
Change of license. I'm not sure how that works legally?
There was a problem hiding this comment.
I will consult with our lawyer to be on a safe side but from what I know Apache License 2 is permissive and compliant with MIT as far as its own conditions fullfilled.
There was a problem hiding this comment.
I've checked with lawyer - Apache License 2 is compatible with MIT. Additional restrictions are mostly that when you use it you have to mention changes specifically and you obliged to publish the code. So I've added detailed changes description.
| @@ -108,6 +117,8 @@ public SOAPMessage incomingRequest(SOAPMessageInfo messageInfo) { | |||
| session.close(); | |||
| chargeBoxes.remove(identity); | |||
| }); | |||
|
|
|||
| // TODO: Decorator created but not used | |||
There was a problem hiding this comment.
I totally missed that one. Thanks
No description provided.