Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched logging to slf4j + logback. #39

Merged
merged 1 commit into from
Apr 16, 2018

Conversation

eupakhomov
Copy link
Contributor

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 57.273% when pulling f71ba02 on eupakhomov:0.5_switch_logging into 72e5393 on ChargeTimeEU:master.

Copy link
Member

@TVolden TVolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine. :)

@TVolden
Copy link
Member

TVolden commented Apr 16, 2018

I checked the IC, it's an unstable integration test (json remote stop)

@eupakhomov
Copy link
Contributor Author

I haven't yet dig into the issue with IC but at firt glance it seems server doesn't start up by the time client expect to. Maybe solution would be to add something like Thread.sleep() or awaitility await() to make it more stable.

@TVolden
Copy link
Member

TVolden commented Apr 16, 2018

This is what I tried to do here: https://github.com/ChargeTimeEU/Java-OCA-OCPP/blob/master/ocpp-v1_6-test/src/test/groovy/eu/chargetime/ocpp/test/core/json/JSONRemoteStopTransactionSpec.groovy#L30-L34

I suspect it's related to the order of the tests, the jsonRemoteStopTransaction is the first test to run after a series of SOAP tests. I can make the test pass, just by restarting the job on Travis.
It's not a constant problem, but mostly isolated to the IC server. I have a local jenkins running without the problem.

@TVolden TVolden merged commit ae696b6 into ChargeTimeEU:master Apr 16, 2018
@TVolden TVolden mentioned this pull request Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants