Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make docker scripts current directory independent #506

Merged
merged 1 commit into from
Jun 4, 2017

Conversation

PlasmaPower
Copy link
Contributor

Instead of cd dev/docker; sudo ./run.sh this allows sudo dev/docker/run.sh.

@PlasmaPower
Copy link
Contributor Author

@e-beach Are you a bot? You seem to be upvoting PRs suspiciously fast and consistently, without watching the repository.

@chaosbot chaosbot removed the ci failed label Jun 4, 2017
@chaosbot
Copy link
Collaborator

chaosbot commented Jun 4, 2017

⚠️ This PR has reached its extended voting window, but it does not have a positive meritocracy review.

Please review: @rudehn @chaosbot @rhengles @hongaar @ad-m @md678685 @xyproto @phil-r @PlasmaPower @eukaryote31 @Smittyvb @viktorsec @muchzer @andrewda @amoffat

@amoffat
Copy link
Contributor

amoffat commented Jun 4, 2017

Random question, why sudo when you launch the container?

@PlasmaPower
Copy link
Contributor Author

@amoffat From the Arch Linux wiki Docker page:

If you want to be able to run docker as a regular user, add yourself to the docker group.

Warning: Anyone added to the docker group is root equivalent. More information here and here.

@amoffat
Copy link
Contributor

amoffat commented Jun 4, 2017

Aha, interesting

@PlasmaPower
Copy link
Contributor Author

This PR also actually needs a meritocracy review.

@rudehn @chaosbot @rhengles @hongaar @ad-m @md678685 @xyproto @phil-r @PlasmaPower @eukaryote31 @Smittyvb @viktorsec @MUCHZER @andrewda @amoffat

@chaosbot chaosbot merged commit efd8114 into Chaosthebot:master Jun 4, 2017
@chaosbot
Copy link
Collaborator

chaosbot commented Jun 4, 2017

✅ PR passed with a vote of 8 for and 0 against, a weighted total of 8.0 and a threshold of 6.5, and a current meritocracy review.

See merge-commit efd8114 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants