Fix dynamic voting window #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlasmaPower
commented
May 27, 2017
| @@ -206,14 +205,13 @@ def get_initial_voting_window(now): | |||
| return seconds | |||
|
|
|||
|
|
|||
| def get_extending_voting_window(api, urn): | |||
| def get_extended_voting_window(api, urn): | |||
There was a problem hiding this comment.
This is the part that was crashing it.
PlasmaPower
commented
May 27, 2017
| @@ -29,6 +29,4 @@ def set_desc(api, urn, desc): | |||
| def get_creation_date(api, urn): | |||
| """ returns the creation date of the repo """ | |||
| data = api("get", get_path(urn)) | |||
| # this is the field for watchers. do not be tricked by "watchers_count" | |||
| # which always matches "stargazers_count" | |||
| return datetime.strptime(data["created_at"], "%Y-%m-%dT%H:%M:%SZ").date() | |||
There was a problem hiding this comment.
Also, how in the world did the PR get through with this comment? Did no one read the changes?
|
Thank you! Sorry for the mess :/ |
|
So how does this get merged in? |
|
@mark-i-m the maintainer of chaosbot merges it. |
|
Ok it's been merged in, thanks for the hotfix @PlasmaPower |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it crashes the server. I've also switched to arrow for anything datetime, as that's the standard for the project and it's a lot better than some hand rolled parsing.