Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for null parameter #22

Merged
merged 3 commits into from
Nov 11, 2022
Merged

Fixes for null parameter #22

merged 3 commits into from
Nov 11, 2022

Conversation

kathibeepboop
Copy link
Contributor

Heyo,

there was a little bug which caused the osc params to not be updated anymore.

In my case there was an Animator param that has been updated, which was not in the VRC params.
This method just ignores null values and doesn´t fire the update event ;)

@ChanyaVRC
Copy link
Owner

Clearly the behavior of Get method etc. will change, so this can not be merged as it is.

Is this the fix of GetValueCallback?
Please write an additional minimal test case to clarify the problem.

@ChanyaVRC
Copy link
Owner

I realize this is the fix of GetValueCallback.
Okey, I make me feel good.

Fixed an issue that stopped reading parameters when receiving not registered avatar parameters on the avatar config file.
}
catch (Exception)
{
// eat exception
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree on that ;) just eat it

@kathibeepboop
Copy link
Contributor Author

Sorry i was kinda busy the last time ;) Thank you reviewing the PR. Its a better way to implement it as "TryGet",

@ChanyaVRC ChanyaVRC merged commit c533ea6 into ChanyaVRC:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants