feat: enable resizing the side panel #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good! could you provide a minimal gif of the result before merging? Thanks! |
|
done! |
|
Moved away from hiding the children component, and used This might introduce a small performance degradation, but it gives more visual feedback to the user, so it's a better solution. |
willydouhard
approved these changes
Jun 13, 2023
- The child component is hidden when resizing to speed up rendering - The handle has a 5px+ border around it to help users select it - Removed the code related to transitions as it wasn't working (transitions were activated on `transform`, `transform` wasn't used)
- Instead of hiding the children, we use `pointer-events` to prevent a potential iframe from messing the resizing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transform,transformwasn't used)Kapture.2023-06-13.at.14.55.00.mp4