Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce perceived latency for users #463

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Reduce perceived latency for users #463

merged 3 commits into from
Oct 9, 2023

Conversation

clementsirieix
Copy link
Collaborator

Before patch:

base.mov

After patch:

patched.mov

Changes

  • In message.py parallelize message persistence
  • In element.py parallelize element persistence

How to test?

  • Upload an element
  • Notice that element can be uploaded and accessed
  • Send a message
  • Notice that persistence occurs after

@clementsirieix clementsirieix added the enhancement New feature or request label Oct 9, 2023
@clementsirieix clementsirieix self-assigned this Oct 9, 2023
willydouhard
willydouhard requested changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@willydouhard willydouhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, few naming changes required.

backend/chainlit/element.py Show resolved Hide resolved
@willydouhard willydouhard merged commit 38439cf into at/CHA-329-rework-user-chat-history Oct 9, 2023
@willydouhard willydouhard deleted the clement/cha-420-reduce-perceived-latency-for-users branch October 9, 2023 16:39
willydouhard added a commit that referenced this pull request Oct 9, 2023
@alimtunc @willydouhard @clementsirieix
Rework user history (#446)
3b7f34f 
* Re implement user chat history

* Reduce perceived latency for users (#463)

* feat/offload persistence

* feat/offload persistence element

---------

Co-authored-by: Clément Sirieix <[email protected]>

---------

Co-authored-by: Willy Douhard <[email protected]>
Co-authored-by: Clément Sirieix <[email protected]>
Co-authored-by: Clément Sirieix <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willydouhard willydouhard Awaiting requested review from willydouhard

Assignees

@clementsirieix clementsirieix

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clementsirieix @willydouhard