Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually run eslint ;) #1530

Merged
merged 6 commits into from
Nov 19, 2024
Merged

Actually run eslint ;) #1530

merged 6 commits into from
Nov 19, 2024

Conversation

dokterbob
Copy link
Collaborator

@dokterbob dokterbob commented Nov 18, 2024

It turned out that:

  • eslint (and tsc) weren't being run for all projects in the workspace, it was only being run for frontend.
  • Moreover, due to a version mismatch between eslint and eslint-typescript, eslint wasn't actually running on frontend either.
  • tsc wasn't configured to run on lint for react-client

This patch resolves this and fixes some minor linting issues which came up.

Note that I ran into issues with tsc validation of copilot -- while this problem didn't occur for react-client. The solutions is probably to use composite in the typescript config's. That's basically workspace support for typescript and should be a separate issue.

@dokterbob dokterbob marked this pull request as ready for review November 18, 2024 23:07
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 18, 2024
@dosubot dosubot bot added the dev-tooling Relating to developer/contributor toolings. label Nov 18, 2024
@dokterbob dokterbob added review-me Ready for review! and removed dev-tooling Relating to developer/contributor toolings. labels Nov 18, 2024
@dokterbob dokterbob merged commit 2bd47f5 into main Nov 19, 2024
9 checks passed
@dokterbob dokterbob deleted the dokterbob/eslint_fixups branch November 19, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-me Ready for review! size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants