@data_layer API hook to configure data layer. #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dokterbob
force-pushed
the
dokterbob/configurable_data_layer
branch
from
85fd27f to
8a03e71
Compare
dosubot
bot
added
the
size:L
dokterbob
added
architecture
5 tasks
willydouhard
reviewed
Nov 6, 2024
It technically might, but it was using a variable intentionally marked as private (e.g. prefixed by The E2E test is updated: https://github.com/Chainlit/chainlit/pull/1463/files#diff-dd1c256dace91e15fad2a2b0f93a821e2dd256dd48ab991c790b059f9bde2d60 I only want to support this API going forward. The old stuff might work and might keep working but should not support it. |
dokterbob
force-pushed
the
dokterbob/configurable_data_layer
branch
from
556105a to
6d7436b
Compare
willydouhard
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cl.datalayerdecorator for configuring data layers, rather than forcing users to override_data_layer.This is a first step towards full support of pluggable data layers.