Fastapi parameter validation #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Regression test for file traversal bug in `project_translations`. * Regression test for `project_settings` path traversal vulnerability. * Regression test for path traversal vulnerability in `get_avatar()`.
dokterbob
force-pushed
the
fastapi_parameter_validation
branch
from
6fe8d85 to
51baf5b
Compare
dokterbob
force-pushed
the
fastapi_parameter_validation
branch
3 times, most recently
from
763bae3 to
92c780d
Compare
* Must build frontend for backend tests... (for now). * Follow ISO spec on Klingon matters.
dokterbob
force-pushed
the
fastapi_parameter_validation
branch
from
38e826c to
54f79d7
Compare
LucasMagnum
reviewed
Sep 24, 2024
|
|
||
| def test_get_avatar_custom(test_client: TestClient, monkeypatch: pytest.MonkeyPatch): | ||
| """Test with custom avatar.""" | ||
| custom_avatar_path = os.path.join( |
There was a problem hiding this comment.
@dokterbob this is assuming that the avatar will be called with correctly which is not the case for the chat. If the assistant name contains space, it will call the API passing that name from the UI and it will return a 400.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate path hierarchy and path parameters for:
get_avatarproject_translationsIncludes test coverage for all relevant methods.