Gracefully handle HTTP errors when sending steps #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Chainlit#1232 Modify Chainlit so that HTTP errors which occur while sending steps to LiteralAI are caught and logged. Prior to this change, HTTP errors such as timeouts result in a series of cascading exceptions and tracebacks that begin with "Task exception was never retrieved" and continue for several traceback iterations. The result is a very verbose log which is hard to understand. With this change we will see one-line error messages in the log rather than a series of tracebacks. In the future we might want to improve this further by retrying (sending the steps again) when the HTTP error is temporary.
|
@willydouhard This will capture HTTP errors with retry logic for all data layer backends. Appreciate your quick review on this. Should you not have time, I'll merge this within 7 days as it seems safe enough for now. |
willydouhard
approved these changes
Aug 22, 2024
|
Thank you @dokterbob and @willydouhard, much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1232
Modify Chainlit so that HTTP errors which occur while sending steps to LiteralAI are caught and logged.
Prior to this change, HTTP errors such as timeouts result in a series of cascading exceptions and tracebacks that begin with "Task exception was never retrieved" and continue for several traceback iterations. The result is a very verbose log which is hard to understand and debug.
After this change we will see one-line error messages in the log when HTTP errors occur, rather than a series of tracebacks.
In the future we might want to improve this further by retrying (sending the steps again) when the HTTP error is temporary.