Python unittest structure #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dokterbob
force-pushed
the
python_unittest_structure
branch
2 times, most recently
from
145f3d1 to
e003a63
Compare
dokterbob
force-pushed
the
python_unittest_structure
branch
from
47291f3 to
b0c3e11
Compare
dokterbob
requested review from
willydouhard,
Dam-Buty,
desaxce,
clementsirieix and
constantinidan
willydouhard
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytest-based infrastructure for running blazingly fast unit tests (seconds) on the backend, in addition to end to end test.
I have used aider to write some initial tests for core functionality (context, emitter, user_session).
Coverage isn't nearly complete, also as I hit some potential bugs which are way beyond the scope of this already quite outsized patch. More tests are in the pipeline, obviously.
For now, I propose this to have infra allowing us to require coverage on modified code and regressions for bugs. That should allow us to significantly bump up velocity while unblocking maintainers. It also paves the way to run tests on multiple versions of Python #1214, FastAPI etc., allowing us to broaden support.
Closes #1134.