fix: update getPendingBalanceToWithdraw to work with uncommitted changes
#7375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #7375 +/- ##
============================================
- Coverage 48.62% 48.61% -0.01%
============================================
Files 603 603
Lines 40516 40520 +4
Branches 2071 2071
============================================
Hits 19700 19700
- Misses 20778 20782 +4
Partials 38 38 |
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
reviewed
Jan 19, 2025
| @@ -76,6 +76,7 @@ export function processWithdrawalRequest( | |||
| withdrawableEpoch, | |||
| }); | |||
| state.pendingPartialWithdrawals.push(pendingPartialWithdrawal); | |||
| state.pendingPartialWithdrawals.commit(); | |||
There was a problem hiding this comment.
can we commit once across multiple withdrawal requests?
eg:
for (...) {
processWithdrawalRequest(...);
}
state.pendingPartialWithdrawals.commit();There was a problem hiding this comment.
the problem is that we need to commit before we call getPendingBalanceToWithdraw
since this calls getAllReadonly
I am sure there is a better solution for this
There was a problem hiding this comment.
so if we don't commit after we push the first withdrawal request the issue happens
There was a problem hiding this comment.
@nflaig calling commit() at the middle of state transition is not great but this is a limitation at ssz side, we should be able to get all items without calling commit()
call state.pendingPartialWithdrawals.getAllReadonly() at the start of processWithdrawalRequest
then modify getPendingBalanceToWithdraw
let total = 0;
for (let i = 0; i < state.pendingPartialWithdrawals.length; i++) {
const item = state.pendingPartialWithdrawals.get(i);
if (item.validatorIndex === validatorIndex) {
total += Number(item.amount);
}
return total;
}performance should be the same, a unit test should help
There was a problem hiding this comment.
call state.pendingPartialWithdrawals.getAllReadonly() at the start of processWithdrawalRequest
I think this would result in the same error, we need to call it outside of this loop
lodestar/packages/state-transition/src/block/processOperations.ts
Lines 74 to 76 in 06831cf
or we add something like cachedPendingPartialWithdrawals which is just a nomral array and we use that instead to check pending balance to withdraw
There was a problem hiding this comment.
or we add something like cachedPendingPartialWithdrawals which is just a nomral array and we use that instead to check pending balance to withdraw
Yea I was thinking about something like this. And whenever state.pendingPartialWithdrawals gets updated during state transition, the cache needs to be updated manually as well.
There was a problem hiding this comment.
something like 582ead5 or you had somehting else in mind?
|
putting as draft for now until more testing is done |
nflaig
commented
Jan 20, 2025
nflaig
changed the title
getPendingBalanceToWithdraw to work with uncommitted pendingPartialWithdrawals
nflaig
changed the title
getPendingBalanceToWithdraw to work with uncommitted pendingPartialWithdrawals getPendingBalanceToWithdraw to work with uncommitted changes
wemeetagain
approved these changes
Jan 20, 2025
wemeetagain
pushed a commit
that referenced
this pull request
Feb 3, 2025
…tation (#7419) Since ChainSafe/ssz#456 it's possible to use `getAllReadonly()` with uncommited changes. This PR essential reverts changes done in #7375 as it causes more memory allocation which is not ideal.
|
🎉 This PR is included in v1.26.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
devnet-5issuewhich happened when processing block with two withdrawal requests.
See discord for more context.