Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip fulu fork spec tests #7343

Merged
merged 1 commit into from
Jan 9, 2025
Merged

chore: skip fulu fork spec tests #7343

merged 1 commit into from
Jan 9, 2025

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Jan 9, 2025

We need to skip fulu fork in our spec tests for now as it otherwise will fail our ssz static tests on devnet-5 branch

Error: TypeError: Cannot read properties of undefined (reading 'AggregateAndProof')
 ❯ Object.fn test/spec/presets/ssz_static.test.ts:47:24
 ❯ test/spec/utils/specTestIterator.ts:152:28

@nflaig nflaig requested a review from a team as a code owner January 9, 2025 21:48
@nflaig nflaig changed the title chore: skip fulu spec tests chore: skip fulu fork spec tests Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.61%. Comparing base (3dc5e8d) to head (52b78fe).
Report is 2 commits behind head on devnet-5.

Additional details and impacted files
@@            Coverage Diff            @@
##           devnet-5    #7343   +/-   ##
=========================================
  Coverage     48.61%   48.61%           
=========================================
  Files           603      603           
  Lines         40534    40534           
  Branches       2071     2071           
=========================================
  Hits          19707    19707           
  Misses        20789    20789           
  Partials         38       38           

@ensi321 ensi321 merged commit 793ad49 into devnet-5 Jan 9, 2025
14 of 18 checks passed
@ensi321 ensi321 deleted the nflaig/skip-fulu branch January 9, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants