Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: batch commit typos and update contributor readme #7312

Merged
merged 3 commits into from
Dec 19, 2024
Merged

docs: batch commit typos and update contributor readme #7312

merged 3 commits into from
Dec 19, 2024

Conversation

philknows
Copy link
Member

Motivation

We've recently experienced many AI-like bots which have been farming minor typos in our repo. We should add an official policy and quote it clearly for contributors what is not an acceptable PR.

Description

This PR formally outlines in our CONTRIBUTING.md document what is not an acceptable PR which are determined to be for farming purposes.

This PR also updates the readme with updated details to meetings and donations.

This PR also incorporates a batch commit for recent typos highlighted by various PRs previously opened for the purposes of farming.

@philknows philknows requested a review from a team as a code owner December 18, 2024 20:20
nazarhussain
nazarhussain requested changes Dec 18, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.75%. Comparing base (7cd296b) to head (b60e6c2).
Report is 4 commits behind head on unstable.

Additional details and impacted files 
@@            Coverage Diff            @@
##           unstable    #7312   +/-   ##
=========================================
  Coverage     48.75%   48.75%           
=========================================
  Files           601      601           
  Lines         40214    40214           
  Branches       2061     2061           
=========================================
  Hits          19608    19608           
  Misses        20568    20568           
  Partials         38       38

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

⚠️ Performance Alert ⚠️

Possible performance regression was detected for some benchmarks.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold.

Benchmark suite Current: 2f9a4e0 Previous: 7cd296b Ratio
Map access 1 prop 0.40400 ns/op 0.13000 ns/op 3.11
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 7.1486 ms/op 2.2918 ms/op 3.12
Full benchmark results
Benchmark suite Current: 2f9a4e0 Previous: 7cd296b Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 1.8795 ms/op 2.1593 ms/op 0.87
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 40.747 us/op 51.437 us/op 0.79
BLS verify - blst 890.90 us/op 868.65 us/op 1.03
BLS verifyMultipleSignatures 3 - blst 1.3023 ms/op 1.2328 ms/op 1.06
BLS verifyMultipleSignatures 8 - blst 2.0617 ms/op 1.7059 ms/op 1.21
BLS verifyMultipleSignatures 32 - blst 4.5404 ms/op 5.0259 ms/op 0.90
BLS verifyMultipleSignatures 64 - blst 8.4506 ms/op 9.2350 ms/op 0.92
BLS verifyMultipleSignatures 128 - blst 16.039 ms/op 17.540 ms/op 0.91
BLS deserializing 10000 signatures 603.26 ms/op 701.23 ms/op 0.86
BLS deserializing 100000 signatures 6.1683 s/op 6.8895 s/op 0.90
BLS verifyMultipleSignatures - same message - 3 - blst 960.39 us/op 839.24 us/op 1.14
BLS verifyMultipleSignatures - same message - 8 - blst 1.1018 ms/op 978.62 us/op 1.13
BLS verifyMultipleSignatures - same message - 32 - blst 1.7112 ms/op 1.6613 ms/op 1.03
BLS verifyMultipleSignatures - same message - 64 - blst 2.5794 ms/op 2.5770 ms/op 1.00
BLS verifyMultipleSignatures - same message - 128 - blst 4.2483 ms/op 4.3364 ms/op 0.98
BLS aggregatePubkeys 32 - blst 18.026 us/op 19.713 us/op 0.91
BLS aggregatePubkeys 128 - blst 63.157 us/op 70.356 us/op 0.90
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 79.740 ms/op 50.963 ms/op 1.56
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 53.079 ms/op 46.474 ms/op 1.14
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 34.930 ms/op 43.698 ms/op 0.80
getSlashingsAndExits - default max 66.084 us/op 95.463 us/op 0.69
getSlashingsAndExits - 2k 217.78 us/op 260.06 us/op 0.84
proposeBlockBody type=full, size=empty 4.9078 ms/op 5.9088 ms/op 0.83
isKnown best case - 1 super set check 464.00 ns/op 276.00 ns/op 1.68
isKnown normal case - 2 super set checks 467.00 ns/op 265.00 ns/op 1.76
isKnown worse case - 16 super set checks 467.00 ns/op 267.00 ns/op 1.75
InMemoryCheckpointStateCache - add get delete 2.5620 us/op 2.8490 us/op 0.90
validate api signedAggregateAndProof - struct 1.9773 ms/op 1.3695 ms/op 1.44
validate gossip signedAggregateAndProof - struct 1.9259 ms/op 1.3907 ms/op 1.38
batch validate gossip attestation - vc 640000 - chunk 32 117.74 us/op 124.18 us/op 0.95
batch validate gossip attestation - vc 640000 - chunk 64 100.47 us/op 108.14 us/op 0.93
batch validate gossip attestation - vc 640000 - chunk 128 100.92 us/op 105.10 us/op 0.96
batch validate gossip attestation - vc 640000 - chunk 256 101.65 us/op 103.07 us/op 0.99
pickEth1Vote - no votes 983.16 us/op 1.0461 ms/op 0.94
pickEth1Vote - max votes 8.1297 ms/op 5.8839 ms/op 1.38
pickEth1Vote - Eth1Data hashTreeRoot value x2048 15.312 ms/op 19.592 ms/op 0.78
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 21.946 ms/op 18.837 ms/op 1.17
pickEth1Vote - Eth1Data fastSerialize value x2048 353.49 us/op 445.26 us/op 0.79
pickEth1Vote - Eth1Data fastSerialize tree x2048 2.8727 ms/op 3.1976 ms/op 0.90
bytes32 toHexString 616.00 ns/op 421.00 ns/op 1.46
bytes32 Buffer.toString(hex) 464.00 ns/op 250.00 ns/op 1.86
bytes32 Buffer.toString(hex) from Uint8Array 587.00 ns/op 358.00 ns/op 1.64
bytes32 Buffer.toString(hex) + 0x 468.00 ns/op 246.00 ns/op 1.90
Object access 1 prop 0.33800 ns/op 0.13100 ns/op 2.58
Map access 1 prop 0.40400 ns/op 0.13000 ns/op 3.11
Object get x1000 5.2880 ns/op 6.0890 ns/op 0.87
Map get x1000 5.8370 ns/op 6.2860 ns/op 0.93
Object set x1000 25.865 ns/op 31.731 ns/op 0.82
Map set x1000 19.270 ns/op 21.883 ns/op 0.88
Return object 10000 times 0.30460 ns/op 0.28510 ns/op 1.07
Throw Error 10000 times 2.7386 us/op 3.3725 us/op 0.81
toHex 112.78 ns/op 156.85 ns/op 0.72
Buffer.from 105.73 ns/op 135.90 ns/op 0.78
shared Buffer 71.932 ns/op 93.813 ns/op 0.77
fastMsgIdFn sha256 / 200 bytes 2.0110 us/op 2.2660 us/op 0.89
fastMsgIdFn h32 xxhash / 200 bytes 432.00 ns/op 228.00 ns/op 1.89
fastMsgIdFn h64 xxhash / 200 bytes 478.00 ns/op 262.00 ns/op 1.82
fastMsgIdFn sha256 / 1000 bytes 6.1180 us/op 7.3390 us/op 0.83
fastMsgIdFn h32 xxhash / 1000 bytes 609.00 ns/op 359.00 ns/op 1.70
fastMsgIdFn h64 xxhash / 1000 bytes 560.00 ns/op 341.00 ns/op 1.64
fastMsgIdFn sha256 / 10000 bytes 50.310 us/op 63.281 us/op 0.80
fastMsgIdFn h32 xxhash / 10000 bytes 2.0670 us/op 1.7940 us/op 1.15
fastMsgIdFn h64 xxhash / 10000 bytes 1.4040 us/op 1.1690 us/op 1.20
send data - 1000 256B messages 9.7790 ms/op 12.098 ms/op 0.81
send data - 1000 512B messages 13.525 ms/op 16.784 ms/op 0.81
send data - 1000 1024B messages 23.308 ms/op 26.458 ms/op 0.88
send data - 1000 1200B messages 22.353 ms/op 25.042 ms/op 0.89
send data - 1000 2048B messages 30.951 ms/op 30.710 ms/op 1.01
send data - 1000 4096B messages 31.129 ms/op 30.865 ms/op 1.01
send data - 1000 16384B messages 68.023 ms/op 73.317 ms/op 0.93
send data - 1000 65536B messages 269.25 ms/op 207.05 ms/op 1.30
enrSubnets - fastDeserialize 64 bits 1.3660 us/op 1.1040 us/op 1.24
enrSubnets - ssz BitVector 64 bits 576.00 ns/op 361.00 ns/op 1.60
enrSubnets - fastDeserialize 4 bits 350.00 ns/op 150.00 ns/op 2.33
enrSubnets - ssz BitVector 4 bits 528.00 ns/op 370.00 ns/op 1.43
prioritizePeers score -10:0 att 32-0.1 sync 2-0 123.35 us/op 169.52 us/op 0.73
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 155.99 us/op 147.80 us/op 1.06
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 307.74 us/op 242.83 us/op 1.27
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 395.59 us/op 394.65 us/op 1.00
prioritizePeers score 0:0 att 64-1 sync 4-1 836.05 us/op 599.96 us/op 1.39
array of 16000 items push then shift 1.2958 us/op 1.6364 us/op 0.79
LinkedList of 16000 items push then shift 8.1040 ns/op 7.0750 ns/op 1.15
array of 16000 items push then pop 128.50 ns/op 124.80 ns/op 1.03
LinkedList of 16000 items push then pop 6.9530 ns/op 7.2270 ns/op 0.96
array of 24000 items push then shift 1.9223 us/op 2.4329 us/op 0.79
LinkedList of 24000 items push then shift 7.7220 ns/op 7.0940 ns/op 1.09
array of 24000 items push then pop 177.90 ns/op 129.96 ns/op 1.37
LinkedList of 24000 items push then pop 6.9240 ns/op 7.4620 ns/op 0.93
intersect bitArray bitLen 8 5.4640 ns/op 6.1910 ns/op 0.88
intersect array and set length 8 39.763 ns/op 44.832 ns/op 0.89
intersect bitArray bitLen 128 25.564 ns/op 28.234 ns/op 0.91
intersect array and set length 128 562.97 ns/op 682.41 ns/op 0.82
bitArray.getTrueBitIndexes() bitLen 128 2.4450 us/op 1.7940 us/op 1.36
bitArray.getTrueBitIndexes() bitLen 248 3.2970 us/op 2.9970 us/op 1.10
bitArray.getTrueBitIndexes() bitLen 512 6.4170 us/op 6.6270 us/op 0.97
Buffer.concat 32 items 995.00 ns/op 877.00 ns/op 1.13
Uint8Array.set 32 items 1.6250 us/op 1.4980 us/op 1.08
Buffer.copy 1.8510 us/op 1.7250 us/op 1.07
Uint8Array.set - with subarray 2.4090 us/op 2.6390 us/op 0.91
Uint8Array.set - without subarray 1.6440 us/op 1.5540 us/op 1.06
getUint32 - dataview 405.00 ns/op 227.00 ns/op 1.78
getUint32 - manual 341.00 ns/op 150.00 ns/op 2.27
Set add up to 64 items then delete first 1.8259 us/op 2.1812 us/op 0.84
OrderedSet add up to 64 items then delete first 2.8545 us/op 3.3461 us/op 0.85
Set add up to 64 items then delete last 2.0598 us/op 2.4431 us/op 0.84
OrderedSet add up to 64 items then delete last 2.9146 us/op 3.8514 us/op 0.76
Set add up to 64 items then delete middle 1.9182 us/op 2.5350 us/op 0.76
OrderedSet add up to 64 items then delete middle 4.2523 us/op 5.2368 us/op 0.81
Set add up to 128 items then delete first 3.7782 us/op 4.9522 us/op 0.76
OrderedSet add up to 128 items then delete first 5.9945 us/op 7.3530 us/op 0.82
Set add up to 128 items then delete last 3.6601 us/op 4.9989 us/op 0.73
OrderedSet add up to 128 items then delete last 5.6254 us/op 7.7791 us/op 0.72
Set add up to 128 items then delete middle 3.6933 us/op 4.9431 us/op 0.75
OrderedSet add up to 128 items then delete middle 11.214 us/op 13.504 us/op 0.83
Set add up to 256 items then delete first 7.4651 us/op 10.130 us/op 0.74
OrderedSet add up to 256 items then delete first 11.958 us/op 15.078 us/op 0.79
Set add up to 256 items then delete last 7.2186 us/op 9.8837 us/op 0.73
OrderedSet add up to 256 items then delete last 11.364 us/op 15.599 us/op 0.73
Set add up to 256 items then delete middle 7.2043 us/op 9.9349 us/op 0.73
OrderedSet add up to 256 items then delete middle 32.796 us/op 40.327 us/op 0.81
transfer serialized Status (84 B) 1.4580 us/op 1.3670 us/op 1.07
copy serialized Status (84 B) 1.2830 us/op 1.1550 us/op 1.11
transfer serialized SignedVoluntaryExit (112 B) 1.7560 us/op 1.4970 us/op 1.17
copy serialized SignedVoluntaryExit (112 B) 1.3860 us/op 1.1740 us/op 1.18
transfer serialized ProposerSlashing (416 B) 2.5450 us/op 2.2110 us/op 1.15
copy serialized ProposerSlashing (416 B) 1.8440 us/op 1.8540 us/op 0.99
transfer serialized Attestation (485 B) 2.2520 us/op 1.5990 us/op 1.41
copy serialized Attestation (485 B) 2.0590 us/op 1.8230 us/op 1.13
transfer serialized AttesterSlashing (33232 B) 2.6460 us/op 2.5300 us/op 1.05
copy serialized AttesterSlashing (33232 B) 5.9510 us/op 5.2980 us/op 1.12
transfer serialized Small SignedBeaconBlock (128000 B) 2.9420 us/op 3.0270 us/op 0.97
copy serialized Small SignedBeaconBlock (128000 B) 10.017 us/op 14.373 us/op 0.70
transfer serialized Avg SignedBeaconBlock (200000 B) 2.8930 us/op 3.5590 us/op 0.81
copy serialized Avg SignedBeaconBlock (200000 B) 13.655 us/op 20.133 us/op 0.68
transfer serialized BlobsSidecar (524380 B) 3.4020 us/op 3.2310 us/op 1.05
copy serialized BlobsSidecar (524380 B) 71.339 us/op 79.338 us/op 0.90
transfer serialized Big SignedBeaconBlock (1000000 B) 3.4860 us/op 3.0660 us/op 1.14
copy serialized Big SignedBeaconBlock (1000000 B) 140.53 us/op 150.18 us/op 0.94
pass gossip attestations to forkchoice per slot 2.3945 ms/op 2.8181 ms/op 0.85
forkChoice updateHead vc 100000 bc 64 eq 0 385.89 us/op 453.06 us/op 0.85
forkChoice updateHead vc 600000 bc 64 eq 0 2.0625 ms/op 2.7395 ms/op 0.75
forkChoice updateHead vc 1000000 bc 64 eq 0 3.8909 ms/op 4.8228 ms/op 0.81
forkChoice updateHead vc 600000 bc 320 eq 0 2.2965 ms/op 2.7927 ms/op 0.82
forkChoice updateHead vc 600000 bc 1200 eq 0 2.3332 ms/op 2.8485 ms/op 0.82
forkChoice updateHead vc 600000 bc 7200 eq 0 3.7401 ms/op 3.4471 ms/op 1.09
forkChoice updateHead vc 600000 bc 64 eq 1000 9.3149 ms/op 10.306 ms/op 0.90
forkChoice updateHead vc 600000 bc 64 eq 10000 8.8042 ms/op 10.648 ms/op 0.83
forkChoice updateHead vc 600000 bc 64 eq 300000 11.228 ms/op 13.456 ms/op 0.83
computeDeltas 500000 validators 300 proto nodes 3.3135 ms/op 3.8810 ms/op 0.85
computeDeltas 500000 validators 1200 proto nodes 3.3044 ms/op 3.8846 ms/op 0.85
computeDeltas 500000 validators 7200 proto nodes 3.4656 ms/op 3.9146 ms/op 0.89
computeDeltas 750000 validators 300 proto nodes 5.3919 ms/op 5.7342 ms/op 0.94
computeDeltas 750000 validators 1200 proto nodes 5.2657 ms/op 5.7394 ms/op 0.92
computeDeltas 750000 validators 7200 proto nodes 5.3351 ms/op 5.7522 ms/op 0.93
computeDeltas 1400000 validators 300 proto nodes 9.8441 ms/op 10.890 ms/op 0.90
computeDeltas 1400000 validators 1200 proto nodes 10.767 ms/op 11.237 ms/op 0.96
computeDeltas 1400000 validators 7200 proto nodes 10.489 ms/op 11.447 ms/op 0.92
computeDeltas 2100000 validators 300 proto nodes 14.478 ms/op 17.096 ms/op 0.85
computeDeltas 2100000 validators 1200 proto nodes 17.529 ms/op 17.219 ms/op 1.02
computeDeltas 2100000 validators 7200 proto nodes 18.152 ms/op 16.359 ms/op 1.11
altair processAttestation - 250000 vs - 7PWei normalcase 1.5501 ms/op 1.6332 ms/op 0.95
altair processAttestation - 250000 vs - 7PWei worstcase 2.3014 ms/op 2.5388 ms/op 0.91
altair processAttestation - setStatus - 1/6 committees join 65.885 us/op 85.035 us/op 0.77
altair processAttestation - setStatus - 1/3 committees join 139.10 us/op 171.28 us/op 0.81
altair processAttestation - setStatus - 1/2 committees join 203.56 us/op 243.55 us/op 0.84
altair processAttestation - setStatus - 2/3 committees join 251.42 us/op 322.27 us/op 0.78
altair processAttestation - setStatus - 4/5 committees join 498.07 us/op 456.60 us/op 1.09
altair processAttestation - setStatus - 100% committees join 496.19 us/op 538.38 us/op 0.92
altair processBlock - 250000 vs - 7PWei normalcase 4.1670 ms/op 3.8267 ms/op 1.09
altair processBlock - 250000 vs - 7PWei normalcase hashState 26.129 ms/op 27.789 ms/op 0.94
altair processBlock - 250000 vs - 7PWei worstcase 32.312 ms/op 33.917 ms/op 0.95
altair processBlock - 250000 vs - 7PWei worstcase hashState 104.23 ms/op 65.694 ms/op 1.59
phase0 processBlock - 250000 vs - 7PWei normalcase 3.0022 ms/op 1.6941 ms/op 1.77
phase0 processBlock - 250000 vs - 7PWei worstcase 25.889 ms/op 19.970 ms/op 1.30
altair processEth1Data - 250000 vs - 7PWei normalcase 276.20 us/op 284.67 us/op 0.97
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 7.5400 us/op 4.9730 us/op 1.52
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 30.391 us/op 27.218 us/op 1.12
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 11.523 us/op 7.8320 us/op 1.47
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 5.7680 us/op 5.2560 us/op 1.10
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 122.95 us/op 112.73 us/op 1.09
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.2979 ms/op 1.1225 ms/op 1.16
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.6513 ms/op 1.5925 ms/op 1.04
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.9356 ms/op 1.5876 ms/op 1.22
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 3.5984 ms/op 3.7245 ms/op 0.97
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.7796 ms/op 1.6464 ms/op 1.08
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 6.1614 ms/op 3.6636 ms/op 1.68
Tree 40 250000 create 528.65 ms/op 206.24 ms/op 2.56
Tree 40 250000 get(125000) 133.63 ns/op 138.66 ns/op 0.96
Tree 40 250000 set(125000) 1.8000 us/op 622.26 ns/op 2.89
Tree 40 250000 toArray() 23.630 ms/op 15.471 ms/op 1.53
Tree 40 250000 iterate all - toArray() + loop 25.180 ms/op 15.536 ms/op 1.62
Tree 40 250000 iterate all - get(i) 57.470 ms/op 50.289 ms/op 1.14
Array 250000 create 4.1630 ms/op 2.8420 ms/op 1.46
Array 250000 clone - spread 5.5124 ms/op 1.4081 ms/op 3.91
Array 250000 get(125000) 0.65300 ns/op 0.40700 ns/op 1.60
Array 250000 set(125000) 0.68400 ns/op 0.42500 ns/op 1.61
Array 250000 iterate all - loop 80.309 us/op 108.02 us/op 0.74
phase0 afterProcessEpoch - 250000 vs - 7PWei 48.013 ms/op 49.478 ms/op 0.97
Array.fill - length 1000000 7.1605 ms/op 3.4760 ms/op 2.06
Array push - length 1000000 26.214 ms/op 16.520 ms/op 1.59
Array.get 0.26598 ns/op 0.27098 ns/op 0.98
Uint8Array.get 0.34793 ns/op 0.43169 ns/op 0.81
phase0 beforeProcessEpoch - 250000 vs - 7PWei 44.740 ms/op 17.611 ms/op 2.54
altair processEpoch - mainnet_e81889 567.61 ms/op 267.97 ms/op 2.12
mainnet_e81889 - altair beforeProcessEpoch 35.241 ms/op 17.905 ms/op 1.97
mainnet_e81889 - altair processJustificationAndFinalization 25.407 us/op 12.314 us/op 2.06
mainnet_e81889 - altair processInactivityUpdates 11.268 ms/op 5.0480 ms/op 2.23
mainnet_e81889 - altair processRewardsAndPenalties 57.384 ms/op 42.383 ms/op 1.35
mainnet_e81889 - altair processRegistryUpdates 5.8330 us/op 1.7240 us/op 3.38
mainnet_e81889 - altair processSlashings 1.2340 us/op 407.00 ns/op 3.03
mainnet_e81889 - altair processEth1DataReset 1.2160 us/op 270.00 ns/op 4.50
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.9501 ms/op 1.9404 ms/op 1.01
mainnet_e81889 - altair processSlashingsReset 5.4340 us/op 3.8820 us/op 1.40
mainnet_e81889 - altair processRandaoMixesReset 6.9310 us/op 4.2130 us/op 1.65
mainnet_e81889 - altair processHistoricalRootsUpdate 1.3340 us/op 470.00 ns/op 2.84
mainnet_e81889 - altair processParticipationFlagUpdates 4.2890 us/op 2.0320 us/op 2.11
mainnet_e81889 - altair processSyncCommitteeUpdates 1.1730 us/op 414.00 ns/op 2.83
mainnet_e81889 - altair afterProcessEpoch 54.645 ms/op 48.728 ms/op 1.12
capella processEpoch - mainnet_e217614 2.0346 s/op 1.0293 s/op 1.98
mainnet_e217614 - capella beforeProcessEpoch 144.82 ms/op 66.293 ms/op 2.18
mainnet_e217614 - capella processJustificationAndFinalization 30.580 us/op 14.509 us/op 2.11
mainnet_e217614 - capella processInactivityUpdates 30.397 ms/op 16.404 ms/op 1.85
mainnet_e217614 - capella processRewardsAndPenalties 424.04 ms/op 224.07 ms/op 1.89
mainnet_e217614 - capella processRegistryUpdates 22.477 us/op 12.199 us/op 1.84
mainnet_e217614 - capella processSlashings 1.4090 us/op 390.00 ns/op 3.61
mainnet_e217614 - capella processEth1DataReset 1.2020 us/op 299.00 ns/op 4.02
mainnet_e217614 - capella processEffectiveBalanceUpdates 28.493 ms/op 11.978 ms/op 2.38
mainnet_e217614 - capella processSlashingsReset 4.8790 us/op 2.3720 us/op 2.06
mainnet_e217614 - capella processRandaoMixesReset 7.2210 us/op 7.0040 us/op 1.03
mainnet_e217614 - capella processHistoricalRootsUpdate 1.1750 us/op 467.00 ns/op 2.52
mainnet_e217614 - capella processParticipationFlagUpdates 4.0330 us/op 1.9490 us/op 2.07
mainnet_e217614 - capella afterProcessEpoch 128.02 ms/op 121.43 ms/op 1.05
phase0 processEpoch - mainnet_e58758 323.21 ms/op 322.95 ms/op 1.00
mainnet_e58758 - phase0 beforeProcessEpoch 79.466 ms/op 65.813 ms/op 1.21
mainnet_e58758 - phase0 processJustificationAndFinalization 12.469 us/op 13.517 us/op 0.92
mainnet_e58758 - phase0 processRewardsAndPenalties 35.592 ms/op 28.646 ms/op 1.24
mainnet_e58758 - phase0 processRegistryUpdates 13.257 us/op 8.0350 us/op 1.65
mainnet_e58758 - phase0 processSlashings 1.3730 us/op 382.00 ns/op 3.59
mainnet_e58758 - phase0 processEth1DataReset 1.3570 us/op 281.00 ns/op 4.83
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.4703 ms/op 1.1657 ms/op 1.26
mainnet_e58758 - phase0 processSlashingsReset 5.5120 us/op 3.1790 us/op 1.73
mainnet_e58758 - phase0 processRandaoMixesReset 10.594 us/op 3.5130 us/op 3.02
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.7870 us/op 334.00 ns/op 5.35
mainnet_e58758 - phase0 processParticipationRecordUpdates 9.6730 us/op 2.8290 us/op 3.42
mainnet_e58758 - phase0 afterProcessEpoch 41.546 ms/op 41.768 ms/op 0.99
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.9492 ms/op 1.3966 ms/op 1.40
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 7.1486 ms/op 2.2918 ms/op 3.12
altair processInactivityUpdates - 250000 normalcase 21.830 ms/op 13.855 ms/op 1.58
altair processInactivityUpdates - 250000 worstcase 20.752 ms/op 14.153 ms/op 1.47
phase0 processRegistryUpdates - 250000 normalcase 13.649 us/op 6.7530 us/op 2.02
phase0 processRegistryUpdates - 250000 badcase_full_deposits 370.90 us/op 241.59 us/op 1.54
phase0 processRegistryUpdates - 250000 worstcase 0.5 178.77 ms/op 114.94 ms/op 1.56
altair processRewardsAndPenalties - 250000 normalcase 56.098 ms/op 36.020 ms/op 1.56
altair processRewardsAndPenalties - 250000 worstcase 48.873 ms/op 34.768 ms/op 1.41
phase0 getAttestationDeltas - 250000 normalcase 6.6674 ms/op 7.5755 ms/op 0.88
phase0 getAttestationDeltas - 250000 worstcase 6.1543 ms/op 7.1731 ms/op 0.86
phase0 processSlashings - 250000 worstcase 96.479 us/op 76.235 us/op 1.27
altair processSyncCommitteeUpdates - 250000 107.38 ms/op 118.09 ms/op 0.91
BeaconState.hashTreeRoot - No change 435.00 ns/op 217.00 ns/op 2.00
BeaconState.hashTreeRoot - 1 full validator 107.99 us/op 101.16 us/op 1.07
BeaconState.hashTreeRoot - 32 full validator 1.1919 ms/op 1.3882 ms/op 0.86
BeaconState.hashTreeRoot - 512 full validator 9.8349 ms/op 10.513 ms/op 0.94
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 141.67 us/op 133.52 us/op 1.06
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.8192 ms/op 1.7057 ms/op 1.07
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 22.860 ms/op 22.304 ms/op 1.02
BeaconState.hashTreeRoot - 1 balances 117.00 us/op 111.30 us/op 1.05
BeaconState.hashTreeRoot - 32 balances 1.1252 ms/op 1.1204 ms/op 1.00
BeaconState.hashTreeRoot - 512 balances 6.5223 ms/op 8.8098 ms/op 0.74
BeaconState.hashTreeRoot - 250000 balances 129.36 ms/op 179.77 ms/op 0.72
aggregationBits - 2048 els - zipIndexesInBitList 19.250 us/op 22.243 us/op 0.87
byteArrayEquals 32 48.241 ns/op 51.490 ns/op 0.94
Buffer.compare 32 15.553 ns/op 16.503 ns/op 0.94
byteArrayEquals 1024 1.2873 us/op 1.5230 us/op 0.85
Buffer.compare 1024 23.025 ns/op 24.620 ns/op 0.94
byteArrayEquals 16384 19.600 us/op 24.259 us/op 0.81
Buffer.compare 16384 185.69 ns/op 197.40 ns/op 0.94
byteArrayEquals 123687377 146.17 ms/op 183.82 ms/op 0.80
Buffer.compare 123687377 5.2804 ms/op 6.1821 ms/op 0.85
byteArrayEquals 32 - diff last byte 45.991 ns/op 50.491 ns/op 0.91
Buffer.compare 32 - diff last byte 15.501 ns/op 16.498 ns/op 0.94
byteArrayEquals 1024 - diff last byte 1.2187 us/op 1.5231 us/op 0.80
Buffer.compare 1024 - diff last byte 21.751 ns/op 24.185 ns/op 0.90
byteArrayEquals 16384 - diff last byte 19.399 us/op 24.225 us/op 0.80
Buffer.compare 16384 - diff last byte 162.38 ns/op 199.47 ns/op 0.81
byteArrayEquals 123687377 - diff last byte 146.17 ms/op 183.26 ms/op 0.80
Buffer.compare 123687377 - diff last byte 5.3224 ms/op 6.2660 ms/op 0.85
byteArrayEquals 32 - random bytes 4.7360 ns/op 4.9480 ns/op 0.96
Buffer.compare 32 - random bytes 15.174 ns/op 16.548 ns/op 0.92
byteArrayEquals 1024 - random bytes 4.7620 ns/op 4.9430 ns/op 0.96
Buffer.compare 1024 - random bytes 14.942 ns/op 16.556 ns/op 0.90
byteArrayEquals 16384 - random bytes 4.7590 ns/op 4.9460 ns/op 0.96
Buffer.compare 16384 - random bytes 14.995 ns/op 16.508 ns/op 0.91
byteArrayEquals 123687377 - random bytes 7.7100 ns/op 6.2000 ns/op 1.24
Buffer.compare 123687377 - random bytes 17.900 ns/op 17.790 ns/op 1.01
regular array get 100000 times 29.813 us/op 31.852 us/op 0.94
wrappedArray get 100000 times 29.814 us/op 31.747 us/op 0.94
arrayWithProxy get 100000 times 9.4562 ms/op 12.573 ms/op 0.75
ssz.Root.equals 42.695 ns/op 44.087 ns/op 0.97
byteArrayEquals 42.026 ns/op 43.442 ns/op 0.97
Buffer.compare 8.7150 ns/op 10.019 ns/op 0.87
processSlot - 1 slots 15.038 us/op 14.549 us/op 1.03
processSlot - 32 slots 2.8460 ms/op 2.8234 ms/op 1.01
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 43.904 ms/op 35.720 ms/op 1.23
getCommitteeAssignments - req 1 vs - 250000 vc 1.8377 ms/op 2.0919 ms/op 0.88
getCommitteeAssignments - req 100 vs - 250000 vc 3.6038 ms/op 4.0451 ms/op 0.89
getCommitteeAssignments - req 1000 vs - 250000 vc 3.8691 ms/op 4.2613 ms/op 0.91
findModifiedValidators - 10000 modified validators 235.49 ms/op 255.77 ms/op 0.92
findModifiedValidators - 1000 modified validators 137.57 ms/op 192.16 ms/op 0.72
findModifiedValidators - 100 modified validators 140.76 ms/op 158.04 ms/op 0.89
findModifiedValidators - 10 modified validators 153.81 ms/op 152.86 ms/op 1.01
findModifiedValidators - 1 modified validators 148.89 ms/op 149.13 ms/op 1.00
findModifiedValidators - no difference 152.64 ms/op 164.02 ms/op 0.93
compare ViewDUs 3.0775 s/op 2.9447 s/op 1.05
compare each validator Uint8Array 1.5505 s/op 1.1038 s/op 1.40
compare ViewDU to Uint8Array 839.17 ms/op 1.0276 s/op 0.82
migrate state 1000000 validators, 24 modified, 0 new 671.04 ms/op 737.26 ms/op 0.91
migrate state 1000000 validators, 1700 modified, 1000 new 972.63 ms/op 982.13 ms/op 0.99
migrate state 1000000 validators, 3400 modified, 2000 new 1.0783 s/op 1.1578 s/op 0.93
migrate state 1500000 validators, 24 modified, 0 new 731.41 ms/op 682.64 ms/op 1.07
migrate state 1500000 validators, 1700 modified, 1000 new 887.96 ms/op 920.34 ms/op 0.96
migrate state 1500000 validators, 3400 modified, 2000 new 1.1456 s/op 1.2039 s/op 0.95
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 6.0800 ns/op 4.5900 ns/op 1.32
state getBlockRootAtSlot - 250000 vs - 7PWei 848.37 ns/op 491.91 ns/op 1.72
computeProposers - vc 250000 6.7089 ms/op 6.9508 ms/op 0.97
computeEpochShuffling - vc 250000 33.998 ms/op 42.145 ms/op 0.81
getNextSyncCommittee - vc 250000 101.44 ms/op 125.18 ms/op 0.81
computeSigningRoot for AttestationData 24.024 us/op 23.094 us/op 1.04
hash AttestationData serialized data then Buffer.toString(base64) 1.1735 us/op 1.6075 us/op 0.73
toHexString serialized data 767.38 ns/op 905.27 ns/op 0.85
Buffer.toString(base64) 151.19 ns/op 176.86 ns/op 0.85
nodejs block root to RootHex using toHex 112.38 ns/op 155.06 ns/op 0.72
nodejs block root to RootHex using toRootHex 71.528 ns/op 92.678 ns/op 0.77
browser block root to RootHex using the deprecated toHexString 203.12 ns/op 228.94 ns/op 0.89
browser block root to RootHex using toHex 165.75 ns/op 182.56 ns/op 0.91
browser block root to RootHex using toRootHex 147.53 ns/op 164.75 ns/op 0.90

by benchmarkbot/action

nflaig
nflaig reviewed Dec 18, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
philknows and others added 2 commits December 18, 2024 19:28
@philknows @nflaig
update donation text
edad2ea 
Co-authored-by: Nico Flaig <[email protected]>
@philknows @nflaig
correct spelling
b60e6c2 
Co-authored-by: Nico Flaig <[email protected]>
nflaig
nflaig approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but @nazarhussain needs to approve since he blocked merging

@nflaig nflaig merged commit ffdfb2e into unstable Dec 19, 2024
17 of 20 checks passed
@nflaig nflaig deleted the philknows/contribution-clarity branch December 19, 2024 19:44
wemeetagain added a commit that referenced this pull request Dec 20, 2024
@wemeetagain @nflaig
@nazarhussain @g11tech @matthewkeil @ensi321 @twoeths @philknows @dependabot @acolytec3 @varunguleriaCodes @ClockworkYuzu
chore: release v1.24.0 (#7325)
11f35a8 
* feat: add keymanager endpoint to retrieve proposer config (#7210)

* feat: add keymanager endpoint to retrieve proposer config

* Do not return empty builder config

* Check all builder proposer config values

* Fix settings builder config if undefined

* Fix builder config parsing

* Use ssz type to handle json serialization

Default parsing can't handle BigInt

* Revert "Use ssz type to handle json serialization"

This reverts commit 01fcea7.

* Fix boost factor json serialization

* Remove unused import

* Update test data

* Update proposer config test

* feat: add mekong network option (#7212)

* chore: fix import order with biome syntax (#7211)

Fix import order

* fix: consistently validate pubkey and throw 404 if not found (#7214)

* Throw error if pubkey is unknown when getting graffiti

* Consistently validate pubkey and throw 404 if not found

* fix: only return local keys from /eth/v1/keystores (#7215)

* fix: only return local keys from /eth/v1/keystores

* Fix fetching remote keys in node assertion

* feat: add and use getBlobsV1 to expedite gossip import (#7134)

* hookup the getblobs api to get bob and proof data from el

remove unused

fix import

metrics overhault, test, debugging testing, some feeback

fix

add nethermind bug dicussion link

fix

resolve conflicts

* deblobs timeout

* fix metric

* chore: revert async aggregate with randomness (#7218)

Revert "feat: asyncAggregateWithRandomness (#7204)"

This reverts commit e31d535.

* fix: update config for relaunched mekong network (#7220)

* fix: light client generating `LightClientUpdate` with wrong length of branches (#7187)

* initial commit

* Rewrite SyncCommitteeWitnessRepository

* Fix finality branch

* Update unit test

* fix e2e

* Review PR

---------

Co-authored-by: Nico Flaig <[email protected]>

* fix: archive finalized state when shutting down beacon node (#7221)

* Fix typo

* feat: remove unfinalized pubkey cache (#7230)

* Remove unfinalized pubkey cache

* lint

* Fix unit test

* chore: skip web3_provider unit tests (#7252)

* fix: prune checkpoint states at syncing time (#7241)

* fix: prune checkpoint states at syncing time

* fix: lint

* fix: check-types in test

* fix: sync cached isCompoundingValidatorArr at epoch transition (#7247)

* fix: handle outOfRangeData when range sync Deneb (#7249)

* fix: handle outOfRangeData for beaconBlocksMaybeBlobsByRange()

* fix: lint

* fix: archiveBlocks - handle deneb outOfRangeData block

* fix: sync cached balance when adding new validator to registry (#7255)

* fix: sync cached balance when adding new validator to registry

* chore: add more comments

* fix: remove persisted checkpoint states from the previous run at startup

* fix: do not throw error when trying to prune missing directory (#7257)

* docs: update documentation Oct 2024 (#7178)

* docs update oct 2024 init

* Reconfig quickstart nav and minor fixes

* fix lint

* spelling fixes

* minor fixes and add to wordlist

* prettier fix

* add to wordlist

* sort wordlist

* modify dominance to include lighthouse

* fix typescript casing and add recommendation

* add selection and boost_factor with keymanager notice

* update wordlist

* remove builder enabled and add keymanager api

* spelling

---------

Co-authored-by: Nico Flaig <[email protected]>

* chore(deps): bump cross-spawn from 7.0.3 to 7.0.6 in /docs (#7268)

Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6.
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md)
- [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6)

---
updated-dependencies:
- dependency-name: cross-spawn
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: add error log to notifier if execution client auth failed (#7239)

* feat: add error log to notifier if execution client auth failed

* Update packages/beacon-node/src/node/notifier.ts

---------

Co-authored-by: NC <[email protected]>

* docs: display rcConfig flag on CLI reference page (#7270)

* docs: display rcConfig flag on CLI reference page

* Update word list

* chore: remove prettier as default formatter for all file types (#7275)

* chore: unhide flags relevant for devnets / testing (#7271)

* feat: debug too many shuffling promises (#7251)

* feat: add asyncShufflingCalculation to StateTransitionOpts

* feat: add asyncShufflingCalculation to all regen / processSlots consumers

* fix: default to false for async shuffling and remove unnecessary props

* fix: remove unnecessary flags from stateTransition

* feat: implement conditional build of shuffling for prepareNextSlot

* fix: spec test bug where shufflingCache is present from BeaconChain constructor

* feat: sync build next shuffling if not queued async

* fix: use getSync to pull next shuffling correctly

* docs: add comment to prepareNextSlot

* refactor: rename StateCloneOpts to StateRegenerationOpts

* feat: pass asyncShufflingCalculation through to afterProcessEpoch and refactor conditional to run purely sync

* docs: add issue number to comment

* chore: lint

* chore: unpin nodejs version from 22.4 (#6982)

* Revert "chore: pin nodejs version to 22.4 (#6964)"

This reverts commit f20484b.

* Don't revert formatting changes

---------

Co-authored-by: Nico Flaig <[email protected]>
Co-authored-by: Cayman <[email protected]>

* chore: update bootnodes file url for holesky and sepolia (#7276)

* feat: add `debug_getHistoricalSummaries` endpoint (#7245)

* feat: add new getHistoricalSummaries endpoint to debug namespace

* Add JSON response

* Restructure to use stateId and add proof to response

* add test scaffolding

* Address feedback

* Move getHistoricalSummaries to lodestar namespace

* add lodestar namespace unit test

* update route name to lodestar namespace

* cast state object as Capella state

* Lint

* json properties need to be lower case

* Make it v1 since it's now part of lodestar namespace

* Group with other /lodestar endpoints

* Simplify beacon node impl

* Rename return type

* Update test description

* Fix variable name

---------

Co-authored-by: Nico Flaig <[email protected]>

* chore: log sync committee signature errors as `error` (#7283)

* fix: update engine_getClientVersionV1 commit encoding (#7282)

* fix: check pubkey or validator index known to a state (#7284)

* fix: check pubkey or validator index known to a state

* chore: add more comments

* feat: lodestar script setup (#7254)

* feat: lodestar_setup

* feat: script_updates + docs

* feat: script_addition_in_docs + command_update

* Remove duplicate script from docs folder

* Minor script updates

* Update script to prepare docs and ignore copied file

* Update installation page

* Wording

---------

Co-authored-by: Nico Flaig <[email protected]>

* feat: add terminal-sized Electra giraffe banner (#7286)

* Create giraffeBanners.ts

* Wire in banner

* Fix file name

* lint

* Address @nflaig's comment

---------

Co-authored-by: NC <[email protected]>

* chore: pin nodejs version to 22.4 (#7291)

Revert "chore: unpin nodejs version from 22.4 (#6982)"

This reverts commit 69ae688.

* feat: expose `DOMAIN_APPLICATION_MASK` in config/spec api (#7296)

* feat: expose DOMAIN_APPLICATION_MASK in config/spec api

* Lint

* feat: make `MAX_REQUEST_BLOB_SIDECARS` and `MAX_BLOBS_PER_BLOCK` configurable (#7294)

* Init commit

* Fix check-types

* Add comment on how MAX_REQUEST_BLOB_SIDECARS is calculated

* Ensure proper config object is passed

* Address comment

---------

Co-authored-by: Nico Flaig <[email protected]>

* feat: use `BLOB_SIDECAR_SUBNET_COUNT` to configure blob subnets (#7297)

feat: use BLOB_SIDECAR_SUBNET_COUNT to configure blob subnets

* chore: log sync aggregate participants when producing beacon block body (#7300)

* chore: log sync aggregate participants when producing beacon block body

* Use isForkLightClient instead of ForkSeq

* Fix produce block unit tests

* chore: print graffiti when producing beacon block body (#7303)

* fix: warn if engine / builder failed to produce block within cutoff time (#7305)

* feat: add kzg commitment length check when validating gossip blocks (#7302)

* feat: add blob sidecar index check (#7313)

Validate blobSidecar index

* fix: fix blob sidecar index check (#7315)

Fix index check

* chore: fix format of printed graffiti from hex to utf-8 (#7306)

* chore: fix format of printed graffiti from hex to utf-8

* Use Buffer.from no copy with offset

* docs: batch commit typos and update contributor readme (#7312)

* batch commit typos and update contributor readme

* update donation text

Co-authored-by: Nico Flaig <[email protected]>

* correct spelling

Co-authored-by: Nico Flaig <[email protected]>

---------

Co-authored-by: Nico Flaig <[email protected]>

* chore: remove trailing null bytes from printed graffiti (#7320)

* chore: remove trailing null bytes from printed graffiti

* Use replaceAll instead of regex

* chore: unpin nodejs version from 22.4 (#7324)

Revert "chore: pin nodejs version to 22.4 (#7291)"

This reverts commit 99794d3.

* chore: bump package versions to 1.24.0

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Nico Flaig <[email protected]>
Co-authored-by: Nazar Hussain <[email protected]>
Co-authored-by: g11tech <[email protected]>
Co-authored-by: Matthew Keil <[email protected]>
Co-authored-by: NC <[email protected]>
Co-authored-by: twoeths <[email protected]>
Co-authored-by: Phil Ngo <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: acolytec3 <[email protected]>
Co-authored-by: Varun Guleria <[email protected]>
Co-authored-by: ClockworkYuzu <[email protected]>
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.24.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nflaig nflaig nflaig approved these changes

@nazarhussain nazarhussain nazarhussain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@philknows @wemeetagain @nazarhussain @nflaig