chore: update block proposal errors dashboard panel #7179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nflaig
commented
Oct 19, 2024
| @@ -499,7 +499,6 @@ export function getDefinitions(config: ChainForkConfig): RouteDefinitions<Endpoi | |||
| const fork = config.getForkName(signedBlindedBlock.message.slot); | |||
| return { | |||
| body: getExecutionForkTypes(fork).SignedBlindedBeaconBlock.toJson(signedBlindedBlock), | |||
|
|
|||
There was a problem hiding this comment.
unrelated but might as well fix formatting here
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #7179 +/- ##
=========================================
Coverage 49.18% 49.18%
=========================================
Files 598 598
Lines 39770 39770
Branches 2092 2092
=========================================
Hits 19560 19560
Misses 20170 20170
Partials 40 40 |
Performance Report✔️ no performance regression detected Full benchmark results
|
twoeths
approved these changes
Oct 21, 2024
|
@nflaig would be great to fix broken "Lodestar - block production" panel "Success + Error" rates, labels are duplicated 
|
|
There are also "dead" panels as we have removed metrics for some of the panels, e.g. all the 3 empty panels here
We have added a different metrics for submitted block proposals in validator monitor which we can use to replace those, also wanna take a look at the local vs. builder %, I thought we had a panel but does not seem to be the case, also noted here #6108 that it did not work as expected |
|
🎉 This PR is included in v1.23.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
operationIdin block proposal errors dashboard panel to use latest version of apis as previous (deprecated) apis are unused in Lodestar by default (and soon to be removed).