Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update electra BuilderBid container #7169

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Oct 16, 2024

Motivation

electra.BuilderBid container is incorrect

Description

Use proper field name as per spec for blob_kzg_commitments

@nflaig nflaig requested a review from a team as a code owner October 16, 2024 11:42
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.00%. Comparing base (1c84d36) to head (1f3d732).
Report is 1 commits behind head on nc/devnet-4.

Additional details and impacted files
@@               Coverage Diff               @@
##           nc/devnet-4    #7169      +/-   ##
===============================================
- Coverage        49.14%   49.00%   -0.14%     
===============================================
  Files              598      596       -2     
  Lines            39848    39790      -58     
  Branches          2077     2058      -19     
===============================================
- Hits             19584    19501      -83     
- Misses           20223    20248      +25     
  Partials            41       41              

@nflaig nflaig merged commit 1d24ed5 into nc/devnet-4 Oct 16, 2024
16 of 17 checks passed
@nflaig nflaig deleted the nflaig/fix-builder-bid branch October 16, 2024 15:36
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.23.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants