-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add vscode settings to split prettier and biome #7149
Conversation
lodestar.code-workspace
Outdated
@@ -0,0 +1,12 @@ | |||
{ | |||
"settings": { | |||
"window.title": "${activeEditorShort}${separator}${rootName}${separator}${profileName}${separator}[${activeRepositoryBranchName}]${separator}[${activeRepositoryBranchName}]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally like having this settings when I have multiple windows of VSCode open. Thought to share with everyone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you share a screenshot how this looks like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #7149 +/- ##
=========================================
Coverage 49.12% 49.12%
=========================================
Files 597 597
Lines 39718 39718
Branches 2085 2080 -5
=========================================
Hits 19512 19512
Misses 20165 20165
Partials 41 41 |
Performance Report✔️ no performance regression detected Full benchmark results
|
should we fix the lint error in this PR? |
Created one for it. #7152 |
54f1580
to
4f9e392
Compare
* Add vscode settings to split prettier and biome * Add whitespace * Fix branch name
🎉 This PR is included in v1.23.0 🎉 |
Motivation
Make sure the
prettier
andbiome
don't override each other.Description
The
biome
formatter works with JS/TS files only (will be extended later). So we keep prettier for rest of the file types.Steps to test or reproduce