Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: async shuffling refactor #6938

Merged
merged 81 commits into from
Sep 23, 2024
Merged

feat: async shuffling refactor #6938

merged 81 commits into from
Sep 23, 2024

Commits on Aug 12, 2024

  1. feat: add ShufflingCache to EpochCache

    @matthewkeil
    matthewkeil committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    46b6b3f View commit details
    Browse the repository at this point in the history

  2. fix: implementation in state-transition for EpochCache with Shuffling… 

    …Cache
    @matthewkeil
    matthewkeil committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    99269ce View commit details
    Browse the repository at this point in the history

  3. feat: remove shufflingCache.processState

    @matthewkeil
    matthewkeil committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    52187c9 View commit details
    Browse the repository at this point in the history

  4. feat: implement ShufflingCache changes in beacon-node

    @matthewkeil
    matthewkeil committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    b6b2f20 View commit details
    Browse the repository at this point in the history

  5. feat: pass shufflingCache when loading cached state from db

    @matthewkeil
    matthewkeil committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    4110dc0 View commit details
    Browse the repository at this point in the history

  6. test: fix state-transition tests for EpochCache changes

    @matthewkeil
    matthewkeil committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    04e4a7b View commit details
    Browse the repository at this point in the history

  7. feat: Pass shufflingCache to EpochCache at startup

    @matthewkeil
    matthewkeil committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    ff2d520 View commit details
    Browse the repository at this point in the history

  8. test: fix slot off by one for decision root in perf test

    @matthewkeil
    matthewkeil committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    53ed72e View commit details
    Browse the repository at this point in the history

  9. chore: use ?. syntax

    @wemeetagain @matthewkeil
    wemeetagain authored and matthewkeil committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    8faee3f View commit details
    Browse the repository at this point in the history

  10. chore: refactoring

    @wemeetagain @matthewkeil
    wemeetagain authored and matthewkeil committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    d69c8b1 View commit details
    Browse the repository at this point in the history

  11. feat: add comments and clean up afterProcessEpoch

    @matthewkeil
    matthewkeil committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    cfa97ad View commit details
    Browse the repository at this point in the history

  12. fix: perf test slot incrementing

    @matthewkeil
    matthewkeil committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    78a60a2 View commit details
    Browse the repository at this point in the history

  13. fix: remove MockShufflingCache

    @matthewkeil
    matthewkeil committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    9b0ffe2 View commit details
    Browse the repository at this point in the history

  14. Revert "chore: refactoring" 

    This reverts commit 104aa56.
    @matthewkeil
    matthewkeil committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    13f5996 View commit details
    Browse the repository at this point in the history

  15. refactor: shufflingCache getters

    @matthewkeil
    matthewkeil committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    d8d69c9 View commit details
    Browse the repository at this point in the history

  16. refactor: shufflingCache setters

    @matthewkeil
    matthewkeil committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    89798a5 View commit details
    Browse the repository at this point in the history

  17. refactor: build and getOrBuild

    @matthewkeil
    matthewkeil committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    81449e4 View commit details
    Browse the repository at this point in the history

  18. docs: add comments to ShufflingCache methods

    @matthewkeil
    matthewkeil committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    5799676 View commit details
    Browse the repository at this point in the history

  19. chore: lint issues

    @matthewkeil
    matthewkeil committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    9a0ca70 View commit details
    Browse the repository at this point in the history

  20. test: update tests in beacon-node

    @matthewkeil
    matthewkeil committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    10dd105 View commit details
    Browse the repository at this point in the history

  21. chore: lint

    @matthewkeil
    matthewkeil committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    bb3fd1c View commit details
    Browse the repository at this point in the history

  22. feat: get shufflings from cache for API

    @matthewkeil
    matthewkeil committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    59f6d3f View commit details
    Browse the repository at this point in the history

  23. feat: minTimeDelayToBuildShuffling cli flag

    @matthewkeil
    matthewkeil committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    bae40cc View commit details
    Browse the repository at this point in the history

  24. test: fix shufflingCache promise insertion test

    @matthewkeil
    matthewkeil committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    b8269ef View commit details
    Browse the repository at this point in the history

  25. fix: rebase conflicts

    @matthewkeil
    matthewkeil committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    a0e7e60 View commit details
    Browse the repository at this point in the history

  26. fix: changes from debugging sim tests

    @matthewkeil
    matthewkeil committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    ff7df85 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. refactor: minimize changes in afterProcessEpoch

    @matthewkeil
    matthewkeil committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    7468419 View commit details
    Browse the repository at this point in the history

  2. chore: fix lint

    @matthewkeil
    matthewkeil committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    9e5e4b0 View commit details
    Browse the repository at this point in the history

  3. chore: fix check-types

    @matthewkeil
    matthewkeil committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    1988568 View commit details
    Browse the repository at this point in the history

  4. chore: fix check-types

    @matthewkeil
    matthewkeil committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    955c66c View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. feat: add diff utility

    @matthewkeil
    matthewkeil committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    389be49 View commit details
    Browse the repository at this point in the history

  2. fix: bug in spec tests from invalid nextActiveIndices

    @matthewkeil
    matthewkeil committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    529d85c View commit details
    Browse the repository at this point in the history

  3. refactor: add/remove comments

    @matthewkeil
    matthewkeil committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    dbf8ff1 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'unstable' into mkeil/shuffling-refactor

    @matthewkeil
    matthewkeil committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    dea45b2 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. refactor: remove this.activeIndicesLength from EpochCache

    @matthewkeil
    matthewkeil committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    5540ce1 View commit details
    Browse the repository at this point in the history

  2. refactor: simplify shufflingCache.getSync

    @matthewkeil
    matthewkeil committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    eb30b75 View commit details
    Browse the repository at this point in the history

  3. refactor: remove unnecessary undefined's

    @matthewkeil
    matthewkeil committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    6388a15 View commit details
    Browse the repository at this point in the history

  4. refactor: clean up ShufflingCache unit test

    @matthewkeil
    matthewkeil committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    b2a7aa2 View commit details
    Browse the repository at this point in the history

  5. feat: add metrics for ShufflingCache

    @matthewkeil
    matthewkeil committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    a8c0a6d View commit details
    Browse the repository at this point in the history

  6. feat: add shufflingCache metrics to state-transition

    @matthewkeil
    matthewkeil committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    40bb572 View commit details
    Browse the repository at this point in the history

  7. chore: lint

    @matthewkeil
    matthewkeil committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    dbe25c9 View commit details
    Browse the repository at this point in the history

  8. fix: metric name clash

    @matthewkeil
    matthewkeil committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    70dc683 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. refactor: add comment about not having ShufflingCache in EpochCache

    @matthewkeil
    matthewkeil committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    27081b2 View commit details
    Browse the repository at this point in the history

  2. refactor: rename shuffling decision root functions

    @matthewkeil
    matthewkeil committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    600acae View commit details
    Browse the repository at this point in the history

  3. refactor: remove unused comment

    @matthewkeil
    matthewkeil committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    8945e03 View commit details
    Browse the repository at this point in the history

  4. feat: async add nextShuffling to EpochCache after its built

    @matthewkeil
    matthewkeil committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    635d74c View commit details
    Browse the repository at this point in the history

  5. feat: make ShufflingCache.set private

    @matthewkeil
    matthewkeil committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    a2ad1ed View commit details
    Browse the repository at this point in the history

  6. feat: chance metrics to nextShufflingNotOnEpochCache instead of posit… 

    …ive case
    @matthewkeil
    matthewkeil committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    db86883 View commit details
    Browse the repository at this point in the history

  7. refactor: move diff to separate PR

    @matthewkeil
    matthewkeil committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    7114aa5 View commit details
    Browse the repository at this point in the history

  8. chore: fix tests using shufflingCache.set method

    @matthewkeil
    matthewkeil committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    4555604 View commit details
    Browse the repository at this point in the history

  9. feat: remove minTimeDelayToBuild

    @matthewkeil
    matthewkeil committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    d49bfee View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. feat: return promise from insertPromise and then through build

    @matthewkeil
    matthewkeil committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    923addb View commit details
    Browse the repository at this point in the history

  2. fix: update metrics names and help field

    @matthewkeil
    matthewkeil committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    1613d8f View commit details
    Browse the repository at this point in the history

  3. feat: move build of shuffling to beforeProcessEpoch

    @matthewkeil
    matthewkeil committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    0a64e36 View commit details
    Browse the repository at this point in the history

  4. feat: allow calc of pivot slot before slot increment

    @matthewkeil
    matthewkeil committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    ed850ee View commit details
    Browse the repository at this point in the history

  5. fix: calc of pivot slot before slot increment

    @matthewkeil
    matthewkeil committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    5e65f7e View commit details
    Browse the repository at this point in the history

  6. Revert "fix: calc of pivot slot before slot increment" 

    This reverts commit 5e65f7e.
    @matthewkeil
    matthewkeil committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    2c1100c View commit details
    Browse the repository at this point in the history

  7. Revert "feat: allow calc of pivot slot before slot increment" 

    This reverts commit ed850ee.
    @matthewkeil
    matthewkeil committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    d5317ec View commit details
    Browse the repository at this point in the history

  8. feat: allow getting current block root for shuffling calculation

    @matthewkeil
    matthewkeil committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    82ac512 View commit details
    Browse the repository at this point in the history

  9. fix: get nextShufflingDecisionRoot directly from state.blockRoots

    @matthewkeil
    matthewkeil committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    aa9ab9c View commit details
    Browse the repository at this point in the history

  10. fix: convert toRootHex

    @matthewkeil
    matthewkeil committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    ca8445a View commit details
    Browse the repository at this point in the history

  11. docs: add comment about pulling decisionRoot directly from state

    @matthewkeil
    matthewkeil committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    19ae447 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. feat: add back metrics for regen attestation cache hit/miss

    @matthewkeil
    matthewkeil committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    ff6694d View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. docs: fix docstring on shufflingCache.build

    @matthewkeil
    matthewkeil committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    1a7ab44 View commit details
    Browse the repository at this point in the history

  2. refactor: change validatorIndices to Uint32Array

    @matthewkeil
    matthewkeil committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    85a9ae1 View commit details
    Browse the repository at this point in the history

  3. refactor: remove comment and change variable name

    @matthewkeil
    matthewkeil committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    ee1256e View commit details
    Browse the repository at this point in the history

  4. fix: use toRootHex instead of toHexString

    @matthewkeil
    matthewkeil committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    eff10c4 View commit details
    Browse the repository at this point in the history

  5. refactor: deduplicate moved function computeAnchorCheckpoint

    @matthewkeil
    matthewkeil committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    4d06deb View commit details
    Browse the repository at this point in the history

  6. fix: touch up metrics per PR comments

    @matthewkeil
    matthewkeil committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    1ab811c View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Merge branch 'unstable' into mkeil/shuffling-refactor

    @matthewkeil
    matthewkeil committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    0e8eeb7 View commit details
    Browse the repository at this point in the history

  2. fix: merge conflict

    @matthewkeil
    matthewkeil committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    fd8196e View commit details
    Browse the repository at this point in the history

  3. chore: lint

    @matthewkeil
    matthewkeil committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    4f777c8 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. refactor: add scope around activeIndices to GC arrays

    @matthewkeil
    matthewkeil committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    222908c View commit details
    Browse the repository at this point in the history

  2. feat: directly use Uint32Array instead of transcribing number array t… 

    …o Uint32Array
    @matthewkeil
    matthewkeil committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    ffbbfea View commit details
    Browse the repository at this point in the history

  3. refactor: activeIndices per tuyen comment

    @matthewkeil
    matthewkeil committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    7f6d420 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. refactor: rename to epochAfterNext

    @matthewkeil
    matthewkeil committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    afc03f2 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. chore: review PR

    @twoeths
    twoeths committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    d1d0e22 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. feat: update no shuffling ApiError to 500 status

    @matthewkeil
    matthewkeil committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c5c5772 View commit details
    Browse the repository at this point in the history

  2. fix: add back unnecessary eslint directive. to be remove under separa… 

    …te PR
    @matthewkeil
    matthewkeil committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    88d3105 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. feat: update no shuffling ApiError to 500 status

    @matthewkeil
    matthewkeil committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b857d6e View commit details
    Browse the repository at this point in the history

  2. docs: add comment about upcomingEpoch

    @matthewkeil
    matthewkeil committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    af5c989 View commit details
    Browse the repository at this point in the history