Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore finalized when processing downloaded unknown block #5651

Merged
merged 2 commits into from
Jun 16, 2023
Merged

fix: ignore finalized when processing downloaded unknown block #5651

merged 2 commits into from
Jun 16, 2023

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Jun 15, 2023

Motivation

  • Got this error in unknown block sync
Error processing block from unknown parent sync root=0xca6db5ca09e886a9747e9401febd1fba11d8bad96af011992c48d8012a3b8821, slot=6661056 code=BLOCK_ERROR_WOULD_REVERT_FINALIZED_SLOT, blockSlot=6661056, finalizedSlot=6661056

If block is before finalized, we only need to ignore it instead of remove all descendant blocks and penalize all related peers

Description

  • Add ignoreIfFinalized flag
  • Add more logs

Closes #5650

@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2023 •
edited
Loading

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: e3fb879 Previous: 08b82af Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 621.04 us/op 861.87 us/op 0.72
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 67.922 us/op 44.613 us/op 1.52
BLS verify - blst-native 1.3455 ms/op 1.2025 ms/op 1.12
BLS verifyMultipleSignatures 3 - blst-native 2.8117 ms/op 2.4456 ms/op 1.15
BLS verifyMultipleSignatures 8 - blst-native 6.0926 ms/op 5.2498 ms/op 1.16
BLS verifyMultipleSignatures 32 - blst-native 21.526 ms/op 18.953 ms/op 1.14
BLS aggregatePubkeys 32 - blst-native 29.621 us/op 25.473 us/op 1.16
BLS aggregatePubkeys 128 - blst-native 110.78 us/op 99.148 us/op 1.12
getAttestationsForBlock 83.739 ms/op 51.761 ms/op 1.62
isKnown best case - 1 super set check 310.00 ns/op 256.00 ns/op 1.21
isKnown normal case - 2 super set checks 294.00 ns/op 250.00 ns/op 1.18
isKnown worse case - 16 super set checks 295.00 ns/op 250.00 ns/op 1.18
CheckpointStateCache - add get delete 6.4600 us/op 4.9070 us/op 1.32
validate gossip signedAggregateAndProof - struct 3.1002 ms/op 2.7556 ms/op 1.13
validate gossip attestation - struct 1.3934 ms/op 1.2818 ms/op 1.09
pickEth1Vote - no votes 1.4671 ms/op 1.2063 ms/op 1.22
pickEth1Vote - max votes 14.937 ms/op 10.430 ms/op 1.43
pickEth1Vote - Eth1Data hashTreeRoot value x2048 10.294 ms/op 8.5794 ms/op 1.20
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 19.727 ms/op 14.616 ms/op 1.35
pickEth1Vote - Eth1Data fastSerialize value x2048 798.27 us/op 625.95 us/op 1.28
pickEth1Vote - Eth1Data fastSerialize tree x2048 6.0531 ms/op 7.3401 ms/op 0.82
bytes32 toHexString 820.00 ns/op 481.00 ns/op 1.70
bytes32 Buffer.toString(hex) 472.00 ns/op 347.00 ns/op 1.36
bytes32 Buffer.toString(hex) from Uint8Array 722.00 ns/op 541.00 ns/op 1.33
bytes32 Buffer.toString(hex) + 0x 473.00 ns/op 348.00 ns/op 1.36
Object access 1 prop 0.23600 ns/op 0.16500 ns/op 1.43
Map access 1 prop 0.19000 ns/op 0.16300 ns/op 1.17
Object get x1000 7.7520 ns/op 7.1930 ns/op 1.08
Map get x1000 0.70300 ns/op 0.59700 ns/op 1.18
Object set x1000 80.651 ns/op 51.495 ns/op 1.57
Map set x1000 61.508 ns/op 42.552 ns/op 1.45
Return object 10000 times 0.28910 ns/op 0.23240 ns/op 1.24
Throw Error 10000 times 4.6982 us/op 4.1435 us/op 1.13
fastMsgIdFn sha256 / 200 bytes 3.8960 us/op 3.4070 us/op 1.14
fastMsgIdFn h32 xxhash / 200 bytes 349.00 ns/op 276.00 ns/op 1.26
fastMsgIdFn h64 xxhash / 200 bytes 565.00 ns/op 390.00 ns/op 1.45
fastMsgIdFn sha256 / 1000 bytes 12.632 us/op 11.364 us/op 1.11
fastMsgIdFn h32 xxhash / 1000 bytes 506.00 ns/op 406.00 ns/op 1.25
fastMsgIdFn h64 xxhash / 1000 bytes 578.00 ns/op 466.00 ns/op 1.24
fastMsgIdFn sha256 / 10000 bytes 114.37 us/op 102.51 us/op 1.12
fastMsgIdFn h32 xxhash / 10000 bytes 2.1670 us/op 1.8500 us/op 1.17
fastMsgIdFn h64 xxhash / 10000 bytes 1.6070 us/op 1.3200 us/op 1.22
enrSubnets - fastDeserialize 64 bits 2.0510 us/op 1.2620 us/op 1.63
enrSubnets - ssz BitVector 64 bits 694.00 ns/op 483.00 ns/op 1.44
enrSubnets - fastDeserialize 4 bits 228.00 ns/op 167.00 ns/op 1.37
enrSubnets - ssz BitVector 4 bits 685.00 ns/op 491.00 ns/op 1.40
prioritizePeers score -10:0 att 32-0.1 sync 2-0 143.29 us/op 106.26 us/op 1.35
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 171.95 us/op 130.84 us/op 1.31
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 214.61 us/op 164.23 us/op 1.31
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 387.29 us/op 301.39 us/op 1.28
prioritizePeers score 0:0 att 64-1 sync 4-1 493.42 us/op 363.19 us/op 1.36
array of 16000 items push then shift 1.8639 us/op 1.6169 us/op 1.15
LinkedList of 16000 items push then shift 10.071 ns/op 8.6840 ns/op 1.16
array of 16000 items push then pop 132.10 ns/op 77.647 ns/op 1.70
LinkedList of 16000 items push then pop 11.365 ns/op 8.4380 ns/op 1.35
array of 24000 items push then shift 2.8204 us/op 2.3975 us/op 1.18
LinkedList of 24000 items push then shift 13.903 ns/op 8.7970 ns/op 1.58
array of 24000 items push then pop 102.87 ns/op 73.699 ns/op 1.40
LinkedList of 24000 items push then pop 12.740 ns/op 8.5420 ns/op 1.49
intersect bitArray bitLen 8 16.900 ns/op 13.388 ns/op 1.26
intersect array and set length 8 145.95 ns/op 78.388 ns/op 1.86
intersect bitArray bitLen 128 58.930 ns/op 43.977 ns/op 1.34
intersect array and set length 128 1.5283 us/op 1.0640 us/op 1.44
Buffer.concat 32 items 3.6210 us/op 2.8300 us/op 1.28
Uint8Array.set 32 items 3.0810 us/op 2.2160 us/op 1.39
transfer serialized Status (84 B) 2.4050 us/op 1.9850 us/op 1.21
copy serialized Status (84 B) 2.3440 us/op 1.7850 us/op 1.31
transfer serialized SignedVoluntaryExit (112 B) 2.7370 us/op 2.2390 us/op 1.22
copy serialized SignedVoluntaryExit (112 B) 2.0640 us/op 1.7720 us/op 1.16
transfer serialized ProposerSlashing (416 B) 3.3290 us/op 2.2380 us/op 1.49
copy serialized ProposerSlashing (416 B) 3.8820 us/op 3.1110 us/op 1.25
transfer serialized Attestation (485 B) 3.3580 us/op 2.7410 us/op 1.23
copy serialized Attestation (485 B) 2.9270 us/op 2.9620 us/op 0.99
transfer serialized AttesterSlashing (33232 B) 3.2210 us/op 2.3590 us/op 1.37
copy serialized AttesterSlashing (33232 B) 11.001 us/op 5.5420 us/op 1.99
transfer serialized Small SignedBeaconBlock (128000 B) 3.7750 us/op 2.9290 us/op 1.29
copy serialized Small SignedBeaconBlock (128000 B) 27.004 us/op 14.609 us/op 1.85
transfer serialized Avg SignedBeaconBlock (200000 B) 4.5080 us/op 3.2450 us/op 1.39
copy serialized Avg SignedBeaconBlock (200000 B) 37.521 us/op 20.498 us/op 1.83
transfer serialized BlobsSidecar (524380 B) 5.2640 us/op 3.1760 us/op 1.66
copy serialized BlobsSidecar (524380 B) 232.16 us/op 164.47 us/op 1.41
transfer serialized Big SignedBeaconBlock (1000000 B) 5.3430 us/op 3.1630 us/op 1.69
copy serialized Big SignedBeaconBlock (1000000 B) 406.35 us/op 139.83 us/op 2.91
pass gossip attestations to forkchoice per slot 3.3370 ms/op 2.6726 ms/op 1.25
forkChoice updateHead vc 100000 bc 64 eq 0 2.3023 ms/op 2.1066 ms/op 1.09
forkChoice updateHead vc 600000 bc 64 eq 0 13.531 ms/op 11.548 ms/op 1.17
forkChoice updateHead vc 1000000 bc 64 eq 0 26.338 ms/op 23.623 ms/op 1.11
forkChoice updateHead vc 600000 bc 320 eq 0 20.890 ms/op 16.351 ms/op 1.28
forkChoice updateHead vc 600000 bc 1200 eq 0 102.89 ms/op 78.310 ms/op 1.31
forkChoice updateHead vc 600000 bc 64 eq 1000 25.103 ms/op 20.384 ms/op 1.23
forkChoice updateHead vc 600000 bc 64 eq 10000 23.977 ms/op 22.786 ms/op 1.05
forkChoice updateHead vc 600000 bc 64 eq 300000 53.478 ms/op 31.028 ms/op 1.72
computeDeltas 4.0491 ms/op 3.8939 ms/op 1.04
computeProposerBoostScoreFromBalances 1.9772 ms/op 1.7686 ms/op 1.12
altair processAttestation - 250000 vs - 7PWei normalcase 3.9425 ms/op 2.1523 ms/op 1.83
altair processAttestation - 250000 vs - 7PWei worstcase 5.2310 ms/op 3.3157 ms/op 1.58
altair processAttestation - setStatus - 1/6 committees join 171.02 us/op 136.58 us/op 1.25
altair processAttestation - setStatus - 1/3 committees join 299.44 us/op 277.35 us/op 1.08
altair processAttestation - setStatus - 1/2 committees join 410.09 us/op 380.68 us/op 1.08
altair processAttestation - setStatus - 2/3 committees join 509.24 us/op 455.87 us/op 1.12
altair processAttestation - setStatus - 4/5 committees join 730.70 us/op 641.93 us/op 1.14
altair processAttestation - setStatus - 100% committees join 883.72 us/op 777.98 us/op 1.14
altair processBlock - 250000 vs - 7PWei normalcase 22.334 ms/op 18.183 ms/op 1.23
altair processBlock - 250000 vs - 7PWei normalcase hashState 35.298 ms/op 29.398 ms/op 1.20
altair processBlock - 250000 vs - 7PWei worstcase 67.449 ms/op 50.025 ms/op 1.35
altair processBlock - 250000 vs - 7PWei worstcase hashState 105.69 ms/op 68.878 ms/op 1.53
phase0 processBlock - 250000 vs - 7PWei normalcase 2.8209 ms/op 1.9575 ms/op 1.44
phase0 processBlock - 250000 vs - 7PWei worstcase 34.809 ms/op 27.651 ms/op 1.26
altair processEth1Data - 250000 vs - 7PWei normalcase 646.11 us/op 458.70 us/op 1.41
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 16.236 us/op 6.5550 us/op 2.48
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 40.672 us/op 19.654 us/op 2.07
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 19.485 us/op 8.3340 us/op 2.34
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 15.450 us/op 6.5670 us/op 2.35
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 136.97 us/op 76.004 us/op 1.80
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 780.83 us/op 637.05 us/op 1.23
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.1972 ms/op 870.43 us/op 1.38
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.2105 ms/op 896.52 us/op 1.35
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 3.4100 ms/op 2.2401 ms/op 1.52
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.9188 ms/op 1.5207 ms/op 1.26
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 7.0595 ms/op 3.8060 ms/op 1.85
Tree 40 250000 create 812.84 ms/op 299.82 ms/op 2.71
Tree 40 250000 get(125000) 221.37 ns/op 178.11 ns/op 1.24
Tree 40 250000 set(125000) 3.0201 us/op 899.64 ns/op 3.36
Tree 40 250000 toArray() 28.462 ms/op 16.707 ms/op 1.70
Tree 40 250000 iterate all - toArray() + loop 29.669 ms/op 16.747 ms/op 1.77
Tree 40 250000 iterate all - get(i) 81.360 ms/op 65.426 ms/op 1.24
MutableVector 250000 create 13.145 ms/op 10.174 ms/op 1.29
MutableVector 250000 get(125000) 7.5490 ns/op 6.2400 ns/op 1.21
MutableVector 250000 set(125000) 509.59 ns/op 260.39 ns/op 1.96
MutableVector 250000 toArray() 4.6224 ms/op 2.9587 ms/op 1.56
MutableVector 250000 iterate all - toArray() + loop 4.9713 ms/op 2.7657 ms/op 1.80
MutableVector 250000 iterate all - get(i) 1.8355 ms/op 1.4813 ms/op 1.24
Array 250000 create 4.3245 ms/op 2.4365 ms/op 1.77
Array 250000 clone - spread 1.8581 ms/op 1.0663 ms/op 1.74
Array 250000 get(125000) 1.9460 ns/op 0.53500 ns/op 3.64
Array 250000 set(125000) 1.6570 ns/op 0.60400 ns/op 2.74
Array 250000 iterate all - loop 115.66 us/op 80.468 us/op 1.44
effectiveBalanceIncrements clone Uint8Array 300000 70.785 us/op 26.624 us/op 2.66
effectiveBalanceIncrements clone MutableVector 300000 857.00 ns/op 327.00 ns/op 2.62
effectiveBalanceIncrements rw all Uint8Array 300000 200.29 us/op 163.94 us/op 1.22
effectiveBalanceIncrements rw all MutableVector 300000 189.93 ms/op 76.106 ms/op 2.50
phase0 afterProcessEpoch - 250000 vs - 7PWei 136.81 ms/op 112.57 ms/op 1.22
phase0 beforeProcessEpoch - 250000 vs - 7PWei 60.839 ms/op 40.398 ms/op 1.51
altair processEpoch - mainnet_e81889 431.32 ms/op 296.75 ms/op 1.45
mainnet_e81889 - altair beforeProcessEpoch 99.476 ms/op 64.106 ms/op 1.55
mainnet_e81889 - altair processJustificationAndFinalization 41.693 us/op 16.325 us/op 2.55
mainnet_e81889 - altair processInactivityUpdates 11.413 ms/op 5.4374 ms/op 2.10
mainnet_e81889 - altair processRewardsAndPenalties 76.191 ms/op 64.647 ms/op 1.18
mainnet_e81889 - altair processRegistryUpdates 6.2770 us/op 2.3380 us/op 2.68
mainnet_e81889 - altair processSlashings 1.5070 us/op 522.00 ns/op 2.89
mainnet_e81889 - altair processEth1DataReset 1.4180 us/op 543.00 ns/op 2.61
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.1042 ms/op 1.2153 ms/op 1.73
mainnet_e81889 - altair processSlashingsReset 9.4660 us/op 3.6100 us/op 2.62
mainnet_e81889 - altair processRandaoMixesReset 9.9650 us/op 4.4910 us/op 2.22
mainnet_e81889 - altair processHistoricalRootsUpdate 2.0690 us/op 747.00 ns/op 2.77
mainnet_e81889 - altair processParticipationFlagUpdates 8.7920 us/op 2.4520 us/op 3.59
mainnet_e81889 - altair processSyncCommitteeUpdates 2.1660 us/op 565.00 ns/op 3.83
mainnet_e81889 - altair afterProcessEpoch 151.67 ms/op 119.40 ms/op 1.27
phase0 processEpoch - mainnet_e58758 487.47 ms/op 317.18 ms/op 1.54
mainnet_e58758 - phase0 beforeProcessEpoch 213.21 ms/op 121.74 ms/op 1.75
mainnet_e58758 - phase0 processJustificationAndFinalization 36.198 us/op 18.716 us/op 1.93
mainnet_e58758 - phase0 processRewardsAndPenalties 85.131 ms/op 55.565 ms/op 1.53
mainnet_e58758 - phase0 processRegistryUpdates 18.095 us/op 7.8480 us/op 2.31
mainnet_e58758 - phase0 processSlashings 1.4300 us/op 585.00 ns/op 2.44
mainnet_e58758 - phase0 processEth1DataReset 1.2890 us/op 520.00 ns/op 2.48
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 4.5366 ms/op 1.0525 ms/op 4.31
mainnet_e58758 - phase0 processSlashingsReset 6.5050 us/op 3.0830 us/op 2.11
mainnet_e58758 - phase0 processRandaoMixesReset 12.513 us/op 4.5210 us/op 2.77
mainnet_e58758 - phase0 processHistoricalRootsUpdate 2.1240 us/op 788.00 ns/op 2.70
mainnet_e58758 - phase0 processParticipationRecordUpdates 12.699 us/op 4.9730 us/op 2.55
mainnet_e58758 - phase0 afterProcessEpoch 113.45 ms/op 92.906 ms/op 1.22
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.8600 ms/op 1.2051 ms/op 1.54
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.4080 ms/op 1.4758 ms/op 1.63
altair processInactivityUpdates - 250000 normalcase 28.220 ms/op 23.552 ms/op 1.20
altair processInactivityUpdates - 250000 worstcase 30.490 ms/op 25.012 ms/op 1.22
phase0 processRegistryUpdates - 250000 normalcase 17.995 us/op 6.1230 us/op 2.94
phase0 processRegistryUpdates - 250000 badcase_full_deposits 327.90 us/op 258.91 us/op 1.27
phase0 processRegistryUpdates - 250000 worstcase 0.5 163.04 ms/op 124.21 ms/op 1.31
altair processRewardsAndPenalties - 250000 normalcase 69.872 ms/op 65.334 ms/op 1.07
altair processRewardsAndPenalties - 250000 worstcase 76.017 ms/op 71.523 ms/op 1.06
phase0 getAttestationDeltas - 250000 normalcase 9.1264 ms/op 6.7452 ms/op 1.35
phase0 getAttestationDeltas - 250000 worstcase 8.3982 ms/op 6.8420 ms/op 1.23
phase0 processSlashings - 250000 worstcase 3.9525 ms/op 3.3790 ms/op 1.17
altair processSyncCommitteeUpdates - 250000 206.55 ms/op 181.12 ms/op 1.14
BeaconState.hashTreeRoot - No change 390.00 ns/op 265.00 ns/op 1.47
BeaconState.hashTreeRoot - 1 full validator 56.831 us/op 54.342 us/op 1.05
BeaconState.hashTreeRoot - 32 full validator 589.33 us/op 561.30 us/op 1.05
BeaconState.hashTreeRoot - 512 full validator 6.7798 ms/op 5.5173 ms/op 1.23
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 73.538 us/op 62.659 us/op 1.17
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 976.24 us/op 986.57 us/op 0.99
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 13.744 ms/op 11.290 ms/op 1.22
BeaconState.hashTreeRoot - 1 balances 56.841 us/op 47.657 us/op 1.19
BeaconState.hashTreeRoot - 32 balances 480.50 us/op 472.13 us/op 1.02
BeaconState.hashTreeRoot - 512 balances 4.7085 ms/op 4.2928 ms/op 1.10
BeaconState.hashTreeRoot - 250000 balances 80.927 ms/op 75.361 ms/op 1.07
aggregationBits - 2048 els - zipIndexesInBitList 25.056 us/op 15.741 us/op 1.59
regular array get 100000 times 47.096 us/op 32.750 us/op 1.44
wrappedArray get 100000 times 37.028 us/op 33.116 us/op 1.12
arrayWithProxy get 100000 times 18.620 ms/op 16.248 ms/op 1.15
ssz.Root.equals 636.00 ns/op 545.00 ns/op 1.17
byteArrayEquals 623.00 ns/op 538.00 ns/op 1.16
shuffle list - 16384 els 7.7662 ms/op 6.8957 ms/op 1.13
shuffle list - 250000 els 110.26 ms/op 100.89 ms/op 1.09
processSlot - 1 slots 9.9050 us/op 9.0470 us/op 1.09
processSlot - 32 slots 1.4901 ms/op 1.3613 ms/op 1.09
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 40.196 ms/op 36.091 ms/op 1.11
getCommitteeAssignments - req 1 vs - 250000 vc 3.2975 ms/op 2.9659 ms/op 1.11
getCommitteeAssignments - req 100 vs - 250000 vc 4.7964 ms/op 4.2150 ms/op 1.14
getCommitteeAssignments - req 1000 vs - 250000 vc 4.9913 ms/op 4.5965 ms/op 1.09
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.6000 ns/op 5.1600 ns/op 1.09
state getBlockRootAtSlot - 250000 vs - 7PWei 760.56 ns/op 636.94 ns/op 1.19
computeProposers - vc 250000 12.492 ms/op 11.109 ms/op 1.12
computeEpochShuffling - vc 250000 116.17 ms/op 107.16 ms/op 1.08
getNextSyncCommittee - vc 250000 211.22 ms/op 185.35 ms/op 1.14
computeSigningRoot for AttestationData 15.999 us/op 13.986 us/op 1.14
hash AttestationData serialized data then Buffer.toString(base64) 2.7450 us/op 2.5438 us/op 1.08
toHexString serialized data 1.9184 us/op 1.1239 us/op 1.71
Buffer.toString(base64) 565.21 ns/op 356.08 ns/op 1.59

by benchmarkbot/action

@dapplion
Copy link
Contributor

Please can you add some test so we don't have a regression latter?

@twoeths
Copy link
Contributor Author

twoeths commented Jun 15, 2023

Screenshot 2023-06-15 at 16 10 13

I stopped a test mainnet for 3h and node is synced very quickly with this PR

@twoeths
Copy link
Contributor Author

twoeths commented Jun 15, 2023

Please can you add some test so we don't have a regression latter?

@dapplion added unit test to reproduce and fix the issue

@twoeths twoeths marked this pull request as ready for review June 15, 2023 11:00
@twoeths twoeths requested a review from a team as a code owner June 15, 2023 11:00
@twoeths twoeths merged commit 2eddf46 into unstable Jun 16, 2023
@twoeths twoeths deleted the tuyen/unknown_block_sync_ignore_finalized branch June 16, 2023 01:22
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.9.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v1.9.0-rc.2] Peers are banned unnecessarily in Unknown Block Sync
3 participants
@twoeths @dapplion @wemeetagain