Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only check parent for maybeUpdateBestChildAndDescendant #5580

Closed
wants to merge 2 commits into from
Closed

fix: only check parent for maybeUpdateBestChildAndDescendant #5580

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edb4145
Only check parent for maybeUpdateBestChildAndDescendant
dapplion May 30, 2023
386c76a
Merge branch 'unstable' into dapplion/forkchoice-onblock-loop
wemeetagain May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/fork-choice/src/protoArray/protoArray.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,15 +217,14 @@ export class ProtoArray {
};

const nodeIndex = this.nodes.length;

this.indices.set(node.blockRoot, nodeIndex);
this.nodes.push(node);

// If this node is valid, lets propagate the valid status up the chain
// and throw error if we counter invalid, as this breaks consensus
if (node.parent !== undefined) {
this.maybeUpdateBestChildAndDescendant(node.parent, nodeIndex, currentSlot);

// If this node is valid, lets propagate the valid status up the chain
// and throw error if we counter invalid, as this breaks consensus
if (node.executionStatus === ExecutionStatus.Valid) {
this.propagateValidExecutionStatusByIndex(node.parent);
}
Expand Down