-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add support for the CI env for e2e tests #5488
Conversation
Performance Report✔️ no performance regression detected Full benchmark results
|
); | ||
|
||
await env.start({runTimeoutMs: 0}); | ||
await connectAllNodes(env.nodes); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this approach leave a network alive for the entire duration of the tests? Which is going through forks? If yes, this means test outcomes of different e2e tests influence each other since they share global state, is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes the network will be alive through out execution of all e2e tests. It's like connecting to external node, but with this the node is configured and running locally.
Every e2e tests should scaffold their specific network condition on this live network. e.g. If one test need to a contract, can deploy it. Or one network need a specific account, can transfer funds from genesis account. This way execution of tests would not effect each other.
5a23f02
to
2580a87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving/merging to unblock other PRs but lets make sure the dicussion here doesn't get lost
🎉 This PR is included in v1.9.0 🎉 |
Motivation
Reduce dependencies of external resources during the e2e tests.
Description
Steps to test or reproduce
Run e2e tests.