refactor!: move network logic into NetworkCore #5351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
dapplion
reviewed
Apr 11, 2023
| /** | ||
| * Some attnet subscription functionality is needed to be mirrored on the chain side of the thread boundary to determine if attestations should be processed | ||
| */ | ||
| export class SimpleAttnetsService { |
There was a problem hiding this comment.
Why is this necessary? This data will be send from the worker to the main thread? IMO:
- Main thread receives validator subscription requests via rest API
- Main thread forward sends those network worker subscription updates
- Worker tracks internal state on what to process and what to subscribe to
- Worker emits gossip object to main thread along with a flag "should_process" or "process_before_slot"
There was a problem hiding this comment.
Also is used when submitting attestations via API, where a process_before_slot is not available
dapplion
changed the title
This was referenced May 1, 2023
|
Converting back to draft |
This was referenced May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In anticipation of moving the network to a separate thread, move all network functionality to a separate module with an interface that may be implemented as a worker thread.
Description
In anticipation of moving the network to a separate thread, move all network functionality to a separate module with an interface that may be implemented as a worker thread.
Pulled into separate PRs
LocalClockinto anEventEmitterthat emitsClockEvents, Allows theNetworkCoreto rely only on a clock for clock events without using the chain directoy. This will be used by the threaded implementation to instantiate its own clock. (refactor!: move clock events to clock class #5446)StatusCacheinstead of the full chain to allowNetworkCoreto get the status without the chain. (refactor(network)!: use StatusCache in PeerManager #5451)Important points
NetworkCorewhich implementsINetworkCoreNetworkimplementation to allow for synchronousgetConnectedPeersandgetConnectedPeerCount.SimpleAttnetsServiceinfo to allow for synchronousshouldProcessAttestationduring gossip and api attestation processingnetworkEventBus->network.events,prepareBeaconCommitteeSubnet->prepareBeaconCommitteeSubnets