Track gossipValidationError metrics by specific error code (#3888)

ChainSafe · Apr 5, 2022 · 60fc678 · 60fc678
1 parent 3218989
commit 60fc678
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/packages/lodestar/src/metrics/metrics/lodestar.ts b/packages/lodestar/src/metrics/metrics/lodestar.ts
@@ -249,6 +249,11 @@ export function createLodestarMetrics(
       help: "Count of total gossip validation reject",
       labelNames: ["topic"],
     }),
+    gossipValidationError: register.gauge<"topic" | "error">({
+      name: "lodestar_gossip_validation_error_total",
+      help: "Count of total gossip validation errors detailed",
+      labelNames: ["topic", "error"],
+    }),
 
     gossipValidationQueueLength: register.gauge<"topic">({
       name: "lodestar_gossip_validation_queue_length",

diff --git a/packages/lodestar/src/network/gossip/validation/index.ts b/packages/lodestar/src/network/gossip/validation/index.ts
@@ -101,6 +101,10 @@ function getGossipValidatorFn<K extends GossipType>(
       const metadata = gossipObject && getGossipObjectAcceptMetadata(config, gossipObject, topic);
       const errorData = {...metadata, ...e.getMetadata()};
 
+      // Metrics on specific error reason
+      // Note: LodestarError.code are bounded pre-declared error messages, not from arbitrary error.message
+      metrics?.gossipValidationError.inc({topic: type, error: (e as GossipActionError<{code: string}>).type.code});
+
       switch (e.action) {
         case GossipAction.IGNORE:
           logger.debug(`gossip - ${type} - ignore`, errorData);