fix!: update multiformats and related dependencies #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`[email protected]` shipped with a [breaking change](multiformats/js-multiformats#230) so update all deps using multiformats to the latest version. The code changed is not used by this module so there's not a lot of changes here, but this should still go out as a major because the interface versions have changed.
achingbrain
commented
Jan 6, 2023
| @@ -72,6 +72,7 @@ async function createJsPeer (options: SpawnOptions): Promise<Daemon> { | |||
| } | |||
|
|
|||
| const opts: Libp2pOptions = { | |||
| // @ts-expect-error @libp2p/interface-peer-id types are not aligned | |||
There was a problem hiding this comment.
This can be removed once [email protected] ships
achingbrain
commented
Jan 6, 2023
| @@ -43,7 +44,7 @@ describe('Index', () => { | |||
| const wrappedInbound = pbStream(inbound.conn) | |||
| const wrappedOutbound = pbStream(outbound.conn) | |||
|
|
|||
| wrappedOutbound.writeLP(Buffer.from('test')) | |||
| wrappedOutbound.writeLP(uint8ArrayFromString('test')) | |||
There was a problem hiding this comment.
This was necessary for the browser tests to pass for me as Buffer is not in the browser global scope.
4 tasks
wemeetagain
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[email protected]shipped with a breaking change so update all deps using multiformats to the latest version.The code changed is not used by this module so there's not a lot of changes here, but this should still go out as a major because the interface versions have changed.